Fix/client comment issue - #3
Open
Flandern1211 wants to merge 4 commits into
Open
Conversation
- 在 clientWR.go 文件中添加了关于 bug 修复的注释说明
- 在 clientWR.go 文件中添加了关于 bug 修复的注释说明
- 修改 writeMessage 函数返回实际写入字节数 - 添加对写入字节数为零的检查并返回错误 - 修复函数末尾错误返回值处理逻辑
- 删除了未使用的 bufio 和 io 导入包 - 移除了不再调用的 readMessage 函数实现 - 简化了客户端代码结构
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two issues with torchaudio/torchcodec in Docker container:
Changes
install.sh: Add torchaudio to pip install commands alongside torch and torchcodec from the same PyTorch index URL
requirements.txt: Remove torchaudio to avoid installing wrong version from PyPI
Dockerfile: Add libnppicc-12 package installation for torchcodec dependency
Test
Build the Docker image and run funasr_asr.py or subfix_webui.py without torchaudio/cuda version errors.