feat: Add ODataClient for Apache HttpClient5#1169
Open
Conversation
…-- all tests green
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| JsonElement resultElement = element; | ||
| for( int i = 0; i < nodes.size(); i++ ) { | ||
| if( resultElement == null || !resultElement.isJsonObject() ) { | ||
| log.warn("JSON path {} could not be resolved for {} at position {}.", path, resultElement, i); |
| if( !resultElement.getAsJsonObject().entrySet().isEmpty() ) { | ||
| resultElement = resultElement.getAsJsonObject().entrySet().iterator().next().getValue(); | ||
| } else { | ||
| log.warn("Wildcard in JSON path {} did not match anything for {}.", path, resultElement); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
SAP/cloud-sdk-java-backlog#504
This PR adds a new module to the Cloud SDK:
datamodel/odata-client-apache-httpclient5. This aims to enable users to use Apaches HttpClient v5 in conjunction with our OData functionalities. I tried to stick as closely to the v4 implementation as possible while respecting the design choices of the new HttpClient v5.This PR does not consider the high-level OData v2 and v4 modules. This will be handled in the future.
Comments regarding review
The first commit of this branch only features the copying of the v4 version of the module. If you want to see the changes that are made compared to our v4 version, look at the changes between the current state of the branch compared to the state after the first commit.
I am also happy to do pair reviews.
Feature scope:
Definition of Done