Fixing issue #373 related to modified-files argument#375
Open
SimoneScalco wants to merge 2 commits intoSAP:mainfrom
Open
Fixing issue #373 related to modified-files argument#375SimoneScalco wants to merge 2 commits intoSAP:mainfrom
SimoneScalco wants to merge 2 commits intoSAP:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for issue #373 related to the usage of modified files.
The usage of
modified-filesgenerated an AttributeError when creating an advisory record inbuild_advisory_record(...).This easy fix changes the
datamodel/advisory.pyfile. More specifically, it was necessary to change this part of the code:Since modified_files is already a set at that point of the code, I changed it to:
I checked other parts of the source code in which modified_files is used. Consequently, I also changed the type annotation related to modified_files in
build_advisory_record(...).As an example, I tested again several different samples. For instance, for
CVE-2021-40690(the same sample posted in the issue) I tested again the following command:After the fix Prospector correctly processes the modified-files argument and provides a report (the report includes all the files that have been specified manually):