[WIP] Fix case sensitivity in waverider-17m-1d THREDDS path

[Copilot]

• Fix syntax error on line 1356 (incomplete list definition)
• Fix case sensitivity: change waverider-17m-1D to waverider-17m-1d on line 1357
• Verify no remaining uppercase D references
• Confirm code compiles successfully
• Run and pass all TestNewGaugeURLLookups tests (8/8)

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

[Copilot]

Pull request overview

This PR fixes a syntax error and case sensitivity issue in the waverider-17m-1d THREDDS path configuration. The malformed list definition on line 1356 has been corrected, and the path on line 1357 now uses lowercase "d" consistently with other gauge paths in the codebase.

Changes:

• Fixed incomplete list definition on line 1356 with proper syntax
• Corrected case sensitivity from waverider-17m-1D to waverider-17m-1d on line 1357

Comments suppressed due to low confidence (33)

murgtools/getdata/getDataFRF.py:476

• This comment appears to contain commented-out code.

        # if specOnly:
        #     wavedata = self.getWaveData(gaugenumber, roundto, removeBadDataFlag, returnAB=returnAB, spec=True)
        #     # work around
        #     return wavedata
        # else:

murgtools/getdata/getDataFRF.py:588

• This comment appears to contain commented-out code.

            # for num in range(0, len(self.curr_time)):
            #     self.curr_time[num] = self.roundtime(self.curr_time[num], roundto=roundto * 60)

murgtools/getdata/getDataFRF.py:959

• This comment appears to contain commented-out code.

        # if self.bathydataindex is None:
        #     self.bathydataindex = []

murgtools/getdata/getDataFRF.py:1745

• This comment appears to contain commented-out code.

                # if isinstance(out['runupDownLine'], np.ma.MaskedArray):
                #     out['runupDownLine'] = np.array(out['runupDownLine'][~out[
                #     'runupDownLine'].mask])
                # else:
                #     pass

murgtools/getdata/getDataFRF.py:3037

• This comment appears to contain commented-out code.

            # if idx.max() not in list:
            #     list = np.append(list, idx.max())

murgtools/getdata/getDataFRF.py:1178

• Testing for None should use the 'is' operator.

        elif (self.bathydataindex == None or len(self.bathydataindex) < 1) & method == 1:

murgtools/getdata/getDataFRF.py:1184

• Testing for None should use the 'is' operator.

        elif (self.bathydataindex == None or len(self.bathydataindex) < 1) and method == 0:

murgtools/getdata/getDataFRF.py:2263

• Testing for None should use the 'is' operator.

        if np.size(self.cbidx) == 1 and self.cbidx == None:

murgtools/getdata/getDataFRF.py:2584

• Testing for None should use the 'is' operator.

        elif (self.bathydataindex == None or len(self.bathydataindex) < 1) and method in [1,

murgtools/getdata/getDataFRF.py:2592

• Testing for None should use the 'is' operator.

        elif (self.bathydataindex == None or np.size(self.bathydataindex) < 1) and method == 0:

murgtools/getdata/getDataFRF.py:2777

• Testing for None should use the 'is' operator.

        elif (self.bathydataindex == None or len(self.bathydataindex) < 1) & method == 1:

murgtools/getdata/getDataFRF.py:2787

• Testing for None should use the 'is' operator.

        elif (self.bathydataindex == None or np.size(self.bathydataindex) < 1) and method == 0:

murgtools/getdata/getDataFRF.py:471

• Variable specOnly is not used.

        specOnly = kwargs.get('specOnly', False)

murgtools/getdata/getDataFRF.py:673

• Variable gname is not used.

            gname = 'Derived wind gauge '

murgtools/getdata/getDataFRF.py:676

• Variable gname is not used.

            gname = '932 wind gauge'

murgtools/getdata/getDataFRF.py:678

• Variable gname is not used.

            gname = '832 wind gauge'

murgtools/getdata/getDataFRF.py:681

• Variable gname is not used.

            gname = '732 wind gauge'

murgtools/getdata/getDataFRF.py:1427

• Variable gname is not used.

            gname = 'AWAC 11m'

murgtools/getdata/getDataFRF.py:2765

• Variable val is not used.

            val = (max([n for n in (self.ncfile['time'][:] - self.epochd1) if n < 0]))

murgtools/getdata/getDataFRF.py:2858

• Variable updateTime is not used.

        updateTime = self.ncfile['updateTime'][idx, ys, xs]

murgtools/getdata/getDataFRF.py:3220

• Variable gname is not used.

            gname = 'There Are no Gauge numbers here'

murgtools/getdata/getDataFRF.py:1644

• This assignment to 'sensor_locations' is unnecessary as it is redefined before this value is used.

                    sensor_locations = collections.OrderedDict()

murgtools/getdata/getDataFRF.py:16

• Import of 'socket' is not used.

import socket

murgtools/getdata/getDataFRF.py:396

• Except block directly handles BaseException.

                    except:

murgtools/getdata/getDataFRF.py:895

• Except block directly handles BaseException.

            except:

murgtools/getdata/getDataFRF.py:1493

• Except block directly handles BaseException.

        except:

murgtools/getdata/getDataFRF.py:2962

• Illegal class 'tuple' raised; will result in a TypeError being raised instead.

            raise (RuntimeError, 'Data not accessible right now')

murgtools/getdata/getDataFRF.py:396

• 'except' clause does nothing but pass and there is no explanatory comment.

                    except:

murgtools/getdata/getDataFRF.py:1114

• 'except' clause does nothing but pass and there is no explanatory comment.

            except:

murgtools/getdata/getDataFRF.py:368

• Unnecessary 'pass' statement.

                    pass

murgtools/getdata/getDataFRF.py:1005

• This statement is unreachable.

                idx = self.bathydataindex

murgtools/getdata/getDataFRF.py:1120

• This statement is unreachable.

            timeunits = 'seconds since 1970-01-01 00:00:00'

murgtools/getdata/getDataFRF.py:2485

• This statement is unreachable.

        try:

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.