Fix ValueError from getnc() returning 3 values but call sites unpacking 2

[Copilot]

After commit bbedac5 changed getnc() to return 3 values (ncFile, allEpoch, indexRef) instead of 2, multiple call sites still unpacked only 2 values, causing runtime ValueError.

Changes

• Updated 12 call sites to unpack 3 values, using _ for unused indexRef:

  • getWind(), getWaterLevel(), getCurrent(), getLidarData(), getCTD(), getCTDtransect(), getCTDquikcat(), getAltimeter(), get1mPhotoData(), getCMSrunTimeseriesatPoint(), getCSHORERuns()

• Simplified getBathyTransectFromNC():

  • Removed conditional len(dataReturns) logic (no longer needed since getnc() always returns 3 values)
  • Handle indexRef=None case: indexRef[0] if indexRef is not None else 0

Example

# Before (ValueError - too many values to unpack)
self.ncfile, self.allEpoch = getnc(dataLoc=self.dataloc, ...)

# After
self.ncfile, self.allEpoch, _ = getnc(dataLoc=self.dataloc, ...)

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

[Copilot]

Copilot wasn't able to review any files in this pull request.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• chldata.erdc.dren.mil
  • Triggering command: /usr/bin/python python -m pytest tests/test_ncml_indexing_regression.py -v (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

[SBFRF]

lgtm