Skip to content

Fix operator precedence bug causing potential UnboundLocalError in getBathyTransectFromNC #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SBFRF merged 4 commits into from
Feb 3, 2026
Merged

Fix operator precedence bug causing potential UnboundLocalError in getBathyTransectFromNC #44

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1e2b19c
Initial plan
Copilot Feb 2, 2026
d798e53
Fix operator precedence bug in getBathyTransectFromNC idx assignment
Copilot Feb 2, 2026
c25d16f
Reorder None check first and fix typo in comment
Copilot Feb 3, 2026
6568b26
Merge branch 'main' into copilot/fix-idx-referenced-before-assignment
SBFRF Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions murgtools/getdata/getDataFRF.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -968,10 +968,9 @@ def getBathyTransectFromNC(self, profilenumbers=None, method=1, forceReturnAll=F
# return everything found in window
idx = self.bathydataindex
elif np.size(self.bathydataindex) == 1 and self.bathydataindex is not None:
# identifed single survey point that fits time window
# identified single survey point that fits time window
idx = self.bathydataindex
elif ((np.size(self.bathydataindex) < 1) or (self.bathydataindex is None) & method == 1) or (
self.bathydataindex is None and method == 1):
elif ((self.bathydataindex is None) or (np.size(self.bathydataindex) < 1)) and method == 1:
# there's no exact bathy match so find the closest in history
# find the max negative number where the negative numbers are historical and the max would be the
# closest historical
Expand Down
Loading