Verify and document FRFcoord multiple point input support#45
Merged
Conversation
Co-authored-by: SBFRF <8375832+SBFRF@users.noreply.github.com>
Co-authored-by: SBFRF <8375832+SBFRF@users.noreply.github.com>
Co-authored-by: SBFRF <8375832+SBFRF@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add capability to FRF coord to operate with multiple input points
Verify and document FRFcoord multiple point input support
Feb 2, 2026
SBFRF
marked this pull request as ready for review
February 3, 2026 01:24
Contributor
There was a problem hiding this comment.
Pull request overview
This PR documents and demonstrates that the FRFcoord function and related coordinate transformation functions already support array inputs for batch coordinate conversion, a capability provided by pyproj >= 3.0.0. No code changes were needed.
Changes:
- Added comprehensive verification documentation (VERIFICATION_FRF_MULTIPLE_POINTS.md) explaining array support, usage examples, and technical details
- Added interactive demonstration script (demo_multiple_point_conversion.py) showing all conversion modes with performance comparisons
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| VERIFICATION_FRF_MULTIPLE_POINTS.md | Documents array input support verification, provides usage examples, and explains technical implementation details |
| examples/demo_multiple_point_conversion.py | Demonstrates single/array conversion modes across all coordinate systems with performance benchmarks |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
FRFcoordfunction already supports array inputs for batch coordinate conversion. This capability exists through pyproj >= 3.0.0'sTransformerclass, which natively handles array transformations.Status
No code changes required. The issue has been resolved by the pyproj library update (version 3.0+), and the existing implementation properly leverages this capability.
Current Behavior
Array Support Coverage
All coordinate transformation functions support array inputs:
FRFcoord()- universal converterFRF2ncsp(),ncsp2FRF()- FRF ↔ State Planencsp2LatLon(),LatLon2ncsp()- State Plane ↔ Lat/LonLatLon2utm(),utm2LatLon()- Lat/Lon ↔ UTMutm2ncsp(),ncsp2utm()- UTM ↔ State PlaneDeliverables
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.