Conversation
…nges - Update test_getWind_returns_expected_keys mock to return 3 values from getnc() - Fix undefined indexRef variable in getWaveHeightValues method - Add noqa comments to long URLs in config.py to pass flake8 All tests now pass (137 passed, 1 skipped) and flake8 linting passes.
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes CI test failures by aligning the test mocks and code with changes from PR 37, where the getnc() function's return signature was updated to consistently return 3 values instead of 2.
Changes:
- Updated test mock for
getWind()to return 3 values fromgetnc()and corrected an outdated comment - Fixed undefined
indexRefvariable ingetWaveSpecModel()method by capturing the third return value fromgetnc() - Added
noqa: E501comments to long URL lines in config.py to satisfy flake8 linting
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/test_getDataFRF.py | Updated test mock to return 3 values from getnc() and corrected misleading comment |
| murgtools/getdata/getDataFRF.py | Fixed undefined indexRef variable by capturing getnc()'s third return value, which is needed for absolute index calculation |
| murgtools/config.py | Added flake8 line length exceptions for long URL constants that cannot be reasonably split |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…nges
All tests now pass (137 passed, 1 skipped) and flake8 linting passes.