Feature/adding blip to caf prod version#187
Open
Jjm321814 wants to merge 67 commits intoproduction/sbnd-gen2from
Open
Feature/adding blip to caf prod version#187Jjm321814 wants to merge 67 commits intoproduction/sbnd-gen2from
Jjm321814 wants to merge 67 commits intoproduction/sbnd-gen2from
Conversation
…truct vs class for blips
Contributor
Author
|
So the new PR live at |
This was referenced Mar 2, 2026
Contributor
Author
|
In initial tests on MC and data I get caf files with blips using reco1 inputs from existing fall production |
Contributor
|
trigger build LArSoft/lar*@LARSOFT_SUITE_v10_14_02_02 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbn*@SBN_SUITE_v10_14_02_03 |
nathanielerowe
approved these changes
Mar 16, 2026
Contributor
nathanielerowe
left a comment
nathanielerowe
left a comment
There was a problem hiding this comment.
Approving since identical to develop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New production PR for blips in CAF
I took the branches from develop, reverted their changes to Feb19 stable versions, then made this new PR.
Original PR aimed at develop and long term use are
sbncode: SBNSoftware/sbncode#603
sbndcode: SBNSoftware/sbndcode#871
sbnobj: SBNSoftware/sbnobj#155
sbnanaobj: #173
I'll post the new PR as a comment to these after all are made