Inverse PISA: a unified input system for AMS - #420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the PLAMS part of the Inverse PISA PR on the main AMS repo:
https://git.scm.com/SCM/amshome/pulls/177
This replaces support for
scm.input_classeswith support forscm.inputs, and replaces all usage of the former in PLAMS. It does break backwards compatibility in the sense thatscm.input_classesare no longer supported and scripts using them will break. IMHO this will be quite rare, as we have never made many examples for the PISA based classes, and I doubt that many customers know about them at all ...