Add Pyomo example smoke coverage#19
Merged
Merged
Conversation
bernalde
commented
May 8, 2026
Member
Author
bernalde
left a comment
There was a problem hiding this comment.
Review summary:
- Blocking issues: None.
- Nonblocking issues: None.
- Questions: None.
- Tests run and outcomes:
- pytest tests/test_example_scripts.py -m "not notebook": 5 passed.
- python examples/example_pyomo_optimizer.py: passed; solved 3 of 3 optimization stages.
- python -m pytest tests/ -n auto -v -m "not notebook and not pyomo" --ignore=tests/test_pyomo_models: 247 passed, 2064 warnings.
- python -m pytest tests/test_web_interface.py -v: 8 passed.
Note: An initial broad run via the pytest console script hit local import-path failures for examples/benchmarks in this non-editable environment; rerunning the same selection through python -m pytest passed.
5. Merge as-is: Yes. GitHub would not accept an APPROVE review from this authenticated user because the user is the PR author, so I am leaving this as COMMENT.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
examples/example_pyomo_optimizer.py.Tests run
python -m pytest tests/test_example_scripts.py::TestPyomoExamples -v -n 0python -m ruff check tests/test_example_scripts.py examples/example_pyomo_optimizer.pypython -m ruff format --check tests/test_example_scripts.py examples/example_pyomo_optimizer.pypython -m pytest tests/ -n auto -v -m "not notebook and not pyomo" --ignore=tests/test_pyomo_modelspython -m mypy lyopronto/python_version = 3.8is no longer supported by that mypy version, but exited successfully.Notes
pr/docs-examplesto target the tail of PR PR 7/7: Pyomo documentation, examples, and CHANGELOG #12, whereexamples/example_pyomo_optimizer.pyis introduced.Closes #14