Add benchmark validation and timeout guards#22
Merged
Conversation
bernalde
commented
May 10, 2026
Member
Author
bernalde
left a comment
There was a problem hiding this comment.
I found blocking issues in the benchmark validation behavior. GitHub does not allow this account to request changes on its own PR, but I would treat this as a request-changes review. The local targeted and CI-equivalent non-notebook/non-Pyomo tests pass, but I would not merge this until the blocking issues above are addressed.
Member
Author
|
Pushed commit Main changes made:
Tests run and results:
Comments intentionally not addressed:
Remaining risks or follow-up items:
|
This was referenced May 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tsh/Pchramp-rate violationsmax_cpu_timeandmax_wall_time, propagate them through Pyomo adapters, and record configured timeout metadataCloses #15
Closes #16
Tests run
python -m compileall benchmarks lyopronto/pyomo_models tests/test_benchmarks.py- passedPYTHONPATH=. pytest tests/test_benchmarks.py -q- 12 passedPYTHONPATH=. pytest tests/ -m "not notebook and not pyomo" -q- 254 passed in 417.56s, no warning summaryPYTHONPATH=. pytest tests/ -m "not notebook and not pyomo" -q -o addopts='-n auto --tb=short --strict-markers --maxfail=1 --dist loadgroup' -W default- 254 passed, confirmed the warnings were expected legacy edge-case warningsNotes
pytest tests/test_benchmarks.py -qwas also tried first, but this branch's pytest configuration does not put the repository root onPYTHONPATH; collection failed withModuleNotFoundError: No module named 'benchmarks'. The tests were rerun withPYTHONPATH=..