Add single-case benchmark runner#24
Merged
Merged
Conversation
bernalde
commented
May 10, 2026
Member
Author
bernalde
left a comment
There was a problem hiding this comment.
Reviewed the PR diff, benchmark adapters, runner code, tests, and benchmark documentation. I did not find blocking issues, nonblocking issues that need an inline comment, or open questions.
Tests run:
python -m ruff check benchmarks/run_single_case.py benchmarks/adapters.py tests/test_benchmarks.py-> passedpython -m ruff format --check benchmarks/run_single_case.py benchmarks/adapters.py tests/test_benchmarks.py-> passedpython -m pytest tests/test_benchmarks.py -q-> passed, 17 passed in 5.04spython -m pytest tests/ -n auto -v -m "not notebook and not pyomo" --ignore=tests/test_pyomo_models-> passed, 254 passed in 383.22s
I did not run the Pyomo-marked live solver suite because it requires the optional IPOPT/IDAES solver stack and is handled separately in CI. The PR is merge-ready from this review.
Member
Author
|
Comment follow-up status:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
benchmarks/run_single_case.py, a no-artifact single-case SciPy/Pyomo debug runner.pyomo_adapter(..., tee=...)and document the new runner inbenchmarks/README.md.Tests run
python -m ruff check benchmarks/run_single_case.py benchmarks/adapters.py tests/test_benchmarks.py-> passed (All checks passed!)python -m ruff format --check benchmarks/run_single_case.py benchmarks/adapters.py tests/test_benchmarks.py-> passed (3 files already formatted)python -m pytest tests/test_benchmarks.py -q-> passed (17 passed in 5.64s)python -m pytest tests/ -n auto -v -m "not notebook and not pyomo" --ignore=tests/test_pyomo_models-> passed (254 passed in 469.66s)Notes
teepropagation is covered directly.Closes #17