Compare paper OCP against LyoPRONTO baselines#35
Open
bernalde wants to merge 1 commit into
Open
Conversation
bernalde
commented
May 11, 2026
Member
Author
bernalde
left a comment
There was a problem hiding this comment.
Blocking issues: none.
Nonblocking issues: none.
Questions: none.
Tests run and outcomes:
- Verified documented benchmark ranges against
benchmarks/results/baseline_Tsh_3x3_summary.jsonlandbenchmarks/results/baseline_Pch_3x3_summary.jsonlwithjq; the documented ranges match the committed data. python -m ruff check tests/test_benchmarks.pypassed.python -m ruff format --check tests/test_benchmarks.pypassed.python -m pytest tests/test_benchmarks.py::test_paper_ocp_notes_cover_issue30_comparison -qpassed, 1 test.python -m pytest tests/test_benchmarks.py -qpassed, 18 tests.python -m pytest tests/ -m "not notebook and not pyomo and not slow" -qpassed, 247 tests.python -m pytest tests/ -n auto -v -m "not notebook and not pyomo" --ignore=tests/test_pyomo_models -qpassed, 262 tests.
I did not run the full Pyomo or notebook suites locally because this PR changes benchmark notes and a lightweight documentation guard test; the CI-style non-Pyomo suite passed, and the stacked PR's visible GitHub checks (Deploy docs, doctests) are green.
Merge recommendation: merge as-is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests run
python -m ruff check tests/test_benchmarks.py- passed.python -m ruff format --check tests/test_benchmarks.py- passed, 1 file already formatted.PYTHONPATH=. pytest tests/test_benchmarks.py::test_paper_ocp_notes_cover_issue30_comparison -q- passed, 1 test in 3.89s.PYTHONPATH=. pytest tests/test_benchmarks.py -q- passed, 18 tests in 5.48s.PYTHONPATH=. pytest tests/ -m "not notebook and not pyomo and not slow" -q- passed, 247 tests in 73.35s.Notes about tests not run
PYTHONPATH=.failed during collection in this shell withModuleNotFoundError: No module named 'benchmarks'; the successful commands above set the repository root onPYTHONPATH.Closes #30