Skip to content

Compare paper OCP against LyoPRONTO baselines#35

Open
bernalde wants to merge 1 commit into
fix/issue-29-problem-2-ocpfrom
fix/issue-30-baseline-comparison
Open

Compare paper OCP against LyoPRONTO baselines#35
bernalde wants to merge 1 commit into
fix/issue-29-problem-2-ocpfrom
fix/issue-30-baseline-comparison

Conversation

@bernalde
Copy link
Copy Markdown
Member

Summary

Tests run

  • python -m ruff check tests/test_benchmarks.py - passed.
  • python -m ruff format --check tests/test_benchmarks.py - passed, 1 file already formatted.
  • PYTHONPATH=. pytest tests/test_benchmarks.py::test_paper_ocp_notes_cover_issue30_comparison -q - passed, 1 test in 3.89s.
  • PYTHONPATH=. pytest tests/test_benchmarks.py -q - passed, 18 tests in 5.48s.
  • PYTHONPATH=. pytest tests/ -m "not notebook and not pyomo and not slow" -q - passed, 247 tests in 73.35s.

Notes about tests not run

  • Full Pyomo, notebook, and slow tests were not run locally because this change is limited to benchmark notes plus a lightweight docs regression test. The broader fast non-Pyomo/non-notebook suite passed.
  • A plain targeted pytest invocation without PYTHONPATH=. failed during collection in this shell with ModuleNotFoundError: No module named 'benchmarks'; the successful commands above set the repository root on PYTHONPATH.

Closes #30

Copy link
Copy Markdown
Member Author

@bernalde bernalde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking issues: none.

Nonblocking issues: none.

Questions: none.

Tests run and outcomes:

  • Verified documented benchmark ranges against benchmarks/results/baseline_Tsh_3x3_summary.jsonl and benchmarks/results/baseline_Pch_3x3_summary.jsonl with jq; the documented ranges match the committed data.
  • python -m ruff check tests/test_benchmarks.py passed.
  • python -m ruff format --check tests/test_benchmarks.py passed.
  • python -m pytest tests/test_benchmarks.py::test_paper_ocp_notes_cover_issue30_comparison -q passed, 1 test.
  • python -m pytest tests/test_benchmarks.py -q passed, 18 tests.
  • python -m pytest tests/ -m "not notebook and not pyomo and not slow" -q passed, 247 tests.
  • python -m pytest tests/ -n auto -v -m "not notebook and not pyomo" --ignore=tests/test_pyomo_models -q passed, 262 tests.

I did not run the full Pyomo or notebook suites locally because this PR changes benchmark notes and a lightweight documentation guard test; the CI-style non-Pyomo suite passed, and the stacked PR's visible GitHub checks (Deploy docs, doctests) are green.

Merge recommendation: merge as-is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant