Revert "fix(fund): Arc raw-key cleanup — key-blind product surfaces (#190)" - #194
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #190 (commit 5197b11).
Why
#190 was marked "Do not merge — TPM/CEO merge gate" in its own body and merged anyway. It also goes the wrong direction: the decision is to remove local-key signing everywhere (see selat-pay #92 / 0.12.0, selat-cli #187 / 0.17.4), not to keep the raw-key Arc deposit path and redact it. #190 added
lib/arc-fund-signer.mjs,lib/redact.mjs, a WeakMap key store and ~300 lines of key-blind tests, all in service of preservingselat fund --chain arcreadingSELAT_PRIVATE_KEY.With selat-discovery #170 also on main, the combined behaviour today is: selat-cli loads the raw key into memory and hands it to a
setup.mjschild that immediately refuses. Dead path, key still touched.Conflict resolution
#193 (help guard + packageRoot) landed after #190 and touches
fund.mjs. Kept #193'swantsFundHelpand its call site; dropped only #190's injectedrun/stdout/stderrparams from thefund()signature. Nothing else in the file referenced them.Tests
npm test: 584/584 (pre-#190 count; #193's help-guard test included).Companion: SELAT-AI/selat-discovery revert of #170. Follow-up (separate PR pair): replace the Arc raw-key deposit with Circle CLI 1.1.1's
gateway deposit --chain ARC --method direct.🤖 Generated with Claude Code