Repository navigation
Conversation
Owner
|
Thanks for the PR! I’m in the middle of rewriting the client, so this part of the codebase is being replaced and I can’t really accept changes against the current implementation anymore. Going to close this, but I appreciate the work and testing you put into it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep Canopy's media information inside its titlebar readout when desktop windows become narrow. Prevent scrolled page content from showing behind the sticky back button and page title.
Root cause
The readout's nested copy grid uses an implicit
autocolumn, whose intrinsic minimum can exceed the space allocated by the outer grid. Bitrate and quality labels also cannot shrink. Separately, the sticky page header has a transparent background.Changes
minmax(0, 1fr)so the existing text ellipsis can work.Only
src/styles/layout-canopy.csschanges. Existing responsive control visibility and breakpoints are preserved.Testing
npm run build:frontend: passed.git diff --check: passed.npm test: 627 passed, 12 failed, 1 skipped. The same 12 failures reproduce on the unmodified baseline; they are in native audio analysis, Windows media integration, and build-mode tests.Browser checks use synthetic data and mocked backend/artwork responses. Electron uses synthetic data in a hidden window with an isolated profile. Visible OS chrome, authenticated playback, native audio/media integration, and macOS/Linux remain untested. Native addons are absent in this checkout. No app console errors occurred in the final browser runs; Chromium emitted WebGL driver performance warnings.
Fixes #136