nnue_train: record embedded trainer build provenance - #412
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Launching a trainer executable from another repository could record that repository's commit in the training experiment. Both training loggers now use the existing Cargo build identity capture. The compatible top-level commit is a full trainer revision (with a dirty suffix); optional params.trainer_build records source cleanliness, compiled backend, compiler and Cargo settings. params.trainer_backend separately records the backend selected for the run.
The build-info command exposes the embedded metadata without initializing CUDA. Build-script tracking covers worktree HEAD/index, common refs and packed refs, and the identity source files. Source archives nested in unrelated repositories and failed Git status queries are treated as unknown. Rescore retains its short commit fingerprint format and dirty/unknown nonce policy.
Validation:
Full scripts/local-ci.sh was attempted. Its oxide-parity compile check fails in the existing pinned cuda-core dependency on Windows with i32/u32 CUDA enum binding mismatches. Oxide kernel generation/parity/equivalence gates therefore remain unverified. This is not reported as a full local-ci PASS.
The provenance document explains Cargo regeneration, stale dirty detection for untracked/unstaged changes, and the limits of source/compiler identity versus executable, dynamic library and external kernel hashes. No checkpoint, data-cursor, QAT or precision changes are included. Concurrent training changes should preserve the provenance fields in both experiment parameter builders.
Independent local reviews: Codex APPROVE and Claude APPROVE. Local commit: 1827fb4.
The owner approved using the successful native validation as the push gate for this PR; the oxide limitations above remain explicit.