fix(transpiler): include diagnostic locations#37
Open
Photon101 wants to merge 1 commit into
Open
Conversation
Photon101
marked this pull request as ready for review
June 11, 2026 04:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Preserve line/column information from type-check diagnostics when
transpileCellFile()returns build errors.Change type
Background / problem
transpileCellFile()already receives diagnostics with positions, but mapped them down tomessagestrings. That meantcell build --jsoncould not show where type-check failures came from.Changes
line N, column M: messagebefore returning them inTranspileResult.errors.errors: string[]shape so current CLI and runtime consumers continue to work.fixtures/broken.cellto exercise a parse-valid, type-check-invalid input and assert the location intranspiler.test.ts.Impact area
Verification
npm run typecheck npm test npm run pack:smoke node --import tsx --test transpiler.test.ts npm run cell:build -- --json fixtures/broken.cell npm run cell:build -- --json ../examples/validator.cell npm run cell:build -- fixtures/broken.cell git diff --checkThe broken build command exits non-zero as expected and now reports
line 1, column 1in both JSON and human output.Test checklist
Screenshots / logs
Not applicable.
Related issue
Closes #32