Repository navigation
[BE] SISC1-224 [FIX] 출석 라운드 관련 수정 #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
The head ref may contain hidden characters: "SISC1-224-BE-\uCD9C\uC11D-\uB77C\uC6B4\uB4DC-\uAD00\uB828-\uC218\uC815"
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
e0d7ec6
refactor: 세션 출석체크 수정
ochanhyeok 4e68429
roundResponse 변수명 수정
ochanhyeok d4f413f
test: 테스트코드 수정
ochanhyeok c67f101
Merge branch 'SISC1-224-BE-출석-라운드-관련-수정' of https://github.com/SISC-I…
ochanhyeok c8c9bfb
fix: attendanceSessionRepository에서 startsAt관련 메서드 제거
ochanhyeok File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
자정을 넘는 세션 시간 처리 문제
LocalTime비교는 자정을 넘는 경우를 올바르게 처리하지 못합니다. 예를 들어 세션이 23:00에 시작하고 60분간 진행되면 종료 시간이 00:00이 되는데, 23:30의currentTime은isBefore(00:00)에서 false를 반환하여 체크인이 불가능하게 됩니다.자정을 넘는 세션이 예상되는 경우 다음과 같이 수정을 고려해 주세요:
public boolean isCheckInAvailableForRound(java.time.LocalTime currentTime) { - return !currentTime.isBefore(defaultStartTime) && currentTime.isBefore(getEndTime()); + LocalTime endTime = getEndTime(); + if (endTime.isBefore(defaultStartTime)) { + // 자정을 넘는 경우 + return !currentTime.isBefore(defaultStartTime) || currentTime.isBefore(endTime); + } + return !currentTime.isBefore(defaultStartTime) && currentTime.isBefore(endTime); }🤖 Prompt for AI Agents