Release v2.0.0: trial-based timing architecture - #3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Merges
release/v2.0.0-prepintomasterfor the neurodesign-plus 2.0.0 release: a source-breaking rework of the timing model around conceptual trials and modeled events, replacing the inherited event-only/ITI-based architecture.Full details:
CHANGES.md·MIGRATION_2.0.mdHighlights
trial_start_interval,post_event_interval,event_transition_interval,inter_trial_interval,rest_every_n_trials,rest_intervalreplace the old ambiguous ITI handling.trial_templates+trials), and probabilistic complete-template sampling (trial_templates+trial_template_probabilities+n_conceptual_trials), replacing event-level template truncation.Experiment.create_design()/create_manual_design()for construction,optimise()→selected_design(rank)for retrieval.SeedSequence/Generatorthroughout, removing global-state reseeding.convergence=k), withgenerations_completed,stop_reason,optimaexposed.tutorials/) covering the v2 workflow end-to-end; renamed/clarified validation scripts undervalidation/; improved public docstrings onExperimentandOptimisation.Breaking changes
stimuli_durations,conditional_ITI,order_keys/order_probabilities/order_length,all_stim_durations,t_pre/t_post,ITImodel/ITImin/ITImean/ITImax, direct.bestdesignreliance."value"instead of"mean"for{"model": "fixed", ...}(uniform/exponential/gaussian rules are unaffected).MIGRATION_2.0.mdfor the full v1 → v2 upgrade path.Validation
71 passed).tests/test_legacy_parity.py.2.0.0acrosspyproject.tomlandCITATION.cff.