Better Prefixes#180
Merged
Merged
Conversation
…interfaces for improved color management
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request refactors the message builder color system to provide better organization and type-specific prefixes. It introduces a new interface-based architecture for color builders and adds dedicated prefix components for different message types (INFO, SUCCESS, WARNING, ERROR).
Changes:
- Refactored color builder methods into separate interface files for better organization
- Added new type-specific prefix components (INFO_PREFIX, SUCCESS_PREFIX, WARNING_PREFIX, ERROR_PREFIX)
- Consolidated number handling in SurfComponentBuilder using a single
Numbertype parameter - Organized Minecraft colors into a dedicated subdirectory
Reviewed changes
Copilot reviewed 33 out of 34 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Colors.kt | Modified PREFIX, added INFO_PREFIX, SUCCESS_PREFIX, WARNING_PREFIX, ERROR_PREFIX components |
| SurfComponentBuilder.kt | Refactored to use ComponentBuilderColors interface, deprecated old prefix methods, consolidated number handling |
| ComponentBuilderColor.kt | New base interface with coloredComponent helper methods |
| ComponentBuilderColors.kt | New aggregator interface combining SurfComponentBuilderColors and MinecraftComponentBuilderColors |
| SurfComponentBuilderColors.kt | Aggregates all Surf-specific color builder interfaces |
| MinecraftComponentBuilderColors.kt | Aggregates all Minecraft color builder interfaces |
| *ComponentBuilderColor.kt (various) | Individual color builder interfaces for each color type |
| surf-api-core-api.api | Updated public API signatures reflecting the refactoring |
| gradle.properties | Version bump from 2.54.3 to 2.55.0 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This superseeds #168