[pull] preview from makeplane:preview - #83
Merged
Conversation
…9513) Bug 5: filtering the work item list by a creation/update date returned an empty list. created_at and updated_at are DateTimeFields, but the UI sends a bare calendar date, and the filterset only exposed `exact` and `range` lookups: - {"created_at__exact": "2026-07-30"} was coerced to 2026-07-30 00:00:00, so it matched only rows stamped exactly midnight — effectively never. - {"created_at__range": "2026-07-28,2026-07-30"} capped the upper bound at 2026-07-30 00:00:00, silently dropping everything created during that final day (the range only "worked" if you overshot the end date by one day). Compare the date component instead (`date` / `date__range` via a CSV-parsing DateCSVRangeFilter), so a calendar date means the whole day and both range bounds are inclusive. The UI's existing query format is unchanged. Verified against a local canary build: the exact requests from the bug report now return 4 and 4 (previously 0 and 0). Adds unit coverage; 6 of the 7 new tests fail without this change. Note: `__date` is evaluated in the active timezone, which TimezoneMixin takes from the user's profile (user_timezone) rather than the browser's timezone, so a profile/browser timezone mismatch can still shift results by a day. Tracked separately — not addressed here. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…RL concatenation (#9512)
…eated_at (#9514) filter_updated_at() passed `created_at__date` as the date term in both its GET and POST branches, so filtering by "Updated At" actually filtered on the creation date. Work items updated today but created earlier never appeared under "Updated At -> is -> today", and the two filters returned identical result sets. Re-raise of community PR #9323 by @sanjibani, which is approved-ready but cannot merge because the CLA is unsigned. Original patch and tests carried over unchanged apart from the two fixes below; credit for the fix is theirs. Adjustments made while porting: - test_get_method_targets_updated_at_column asserted the exact key "updated_at__date", but date_filter's single-value branch appends a lookup suffix ("updated_at__date__contains"), so the assertion always failed. Match on the key prefix instead. - Added the missing trailing newline to the new test file. Verified on a local canary build: with one work item created 2020-01-01 but updated today, `?updated_at=2026-07-01;after` now returns 5 while `?created_at=2026-07-01;after` returns 4 — previously both returned 4. Unit tests pass (5); 4 of the 5 fail without the source change. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )