Added MAX_MULTICALL_BATCH_SIZE - #706
Merged
Merged
Conversation
…icall Add MAX_MULTICALL_BATCH_SIZE (20) constant and check actions.len() against it at the top of multicall, panicking with the already-declared BatchSizeLimitExceeded error when exceeded.
Replace get_position_price_impact with get_swap_price_impact in reader::estimate_swap_output, matching the formula swap_utils actually uses at execution time. Move output_price computation before the impact call since get_swap_price_impact requires it.
…act map Both contracts have their own crates, are listed in the CONTRACTS build target, and carry mainnet network-ID guards — they are real deployable contracts, not just internal test fixtures. This fills the same gap issue SO4-Markets#401 fixed for four other periphery contracts.
|
@0xSlink Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #575 — Added MAX_MULTICALL_BATCH_SIZE = 20 constant and bounds check in multicall that panics with the existing BatchSizeLimitExceeded error (contracts/exchange_router/src/lib.rs)
Closes #555 — Replaced get_position_price_impact with get_swap_price_impact in reader::estimate_swap_output, matching the formula swap_utils actually uses at execution time. Moved output_price computation before the impact call (contracts/reader/src/lib.rs)
Closes #560 — Added test_faucet and test_token rows to both the Contract Mapa table and Project Structure section in README.md
Closes #561 (test coverage for test_faucet) was passed