chore(libs): remove storage_ttl dead code for wrong SDK (#534) - #707
Open
ZacLou wants to merge 1 commit into
Open
chore(libs): remove storage_ttl dead code for wrong SDK (#534)#707ZacLou wants to merge 1 commit into
ZacLou wants to merge 1 commit into
Conversation
) Closes SO4-Markets#534 libs/storage_ttl was written against multiversx_sc, not soroban_sdk, and is not referenced by any workspace member or other crate. Remove it following the precedent of libs/deposit_flow, libs/withdrawal_flow, and libs/position_list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #534
libs/storage_ttl was written entirely against multiversx_sc and is not listed in the workspace members. No other crate or contract references it. This removes the directory, matching the precedent set by libs/deposit_flow, libs/withdrawal_flow, and libs/position_list.
Verification: grep -rn storage_ttl --include='.rs' --include='.toml' . returns no output outside the deleted directory.