Fix ConsumerGroupStream commit payload type#1284
Open
iffyio wants to merge 1 commit into
Open
Conversation
Currently, the payload argument for the `commit` method is declared as type `Message` interface which in turn expects a `value` field that offset requests do not have (This forces workarounds like inserting a dummy value to get around the type-checker). This patch fixes this by specifying the commit payload to be of type `OffsetCommitRequest` which declares the sufficient fields of commit payloads.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the payload argument for the
commitmethod is declared as type
Messageinterface whichin turn expects a
valuefield that offset requests donot have (This forces workarounds like inserting a dummy
value to get around the type-checker).
This patch fixes this by specifying the commit payload
to be of type
OffsetCommitRequestwhich declaresthe sufficient fields of commit payloads.