Fixed isAsync params usage for createTopics (#900)#1370
Open
lamweili wants to merge 3 commits into
Open
Conversation
lamweili
changed the title
lamweili
force-pushed
the
BugFix/isAsync-params-usage-for-createTopics
branch
4 times, most recently
from
b870e34 to
fd08af2
Compare
Async must default to false. It is dangerous to use async=true for createTopics unless explicitly specified. For running async calls, the subsequent steps (such as addTopics) will fail as the topics are yet to be created/in the progress of creation. It is the nature of async to return immediately even before the createTopics is completed. This fixes the regression from the fix 5fd3764.
lamweili
force-pushed
the
BugFix/isAsync-params-usage-for-createTopics
branch
from
fd08af2 to
b7b1953
Compare
(To be consistent with test.highLevelProducer.js line 24)
lamweili
force-pushed
the
BugFix/isAsync-params-usage-for-createTopics
branch
from
2f88591 to
8526b0b
Compare
Author
|
I noticed that most of the pull requests have the following error from the Travis-CI test report:
Some examples are #1612.4 and #1612.7 of This error has got nothing to do with the pull requests, but rather a test suite issue. I have patched test.producer.js to use uuid.v4() instead of Date.now() in the topic name, to reduce the risk of collision (8526b0b). Especially when Travis-CI runs multiple environments concurrently, it is highly likely that Date.now() might not be unique enough. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #900 - The README documentation is wrong/unclear