feat: central frontend store (RDFA-483) by tarn-soptim · Pull Request #128 · SOPTIM/RDFArchitect

tarn-soptim · 2026-05-26T14:21:07Z

Description

Test Checklist

General Behavior

Components reload automatically when data changes
Editing features are disabled in readonly datasets
Dialogs pre-select current dataset/graph
Required fields are validated in dialogs
Discarding unsaved changes opens a discard cancel confirm dialog

Global MenuBar

Welcome Page

Navigation to Editor works
Tips are displayed
Security and data information displayed
Copyright and version information displayed

Editor - MenuBar

Search function works with all filters (All Datasets, Current Dataset, Current Graph, Current Package)
Search finds classes, attributes, associations, packages
"Enable Editing" button appears for readonly datasets

Editor - Navigation

Editor - Package View

Class diagram displays correctly
Moving nodes works and layout changes persist after reload
Loading animation shows while loading
Info cards show when no package or no classes available
Drag and zoom diagram works
"Reset View" button works
"Filter View" works
"Reset Layout" button resets diagram to auto-generated layout
Click on class opens class editor

Editor - Class Editor

Display and edit class properties: Label, Namespace, Package, Derived from, Abstract, Stereotypes, Attributes, Associations, Comment
Delete class works
Save changes works
Discard changes works
Attribute Editor works
Association Editor works
attribute/association SHACL View works
Class SHACL View works

Prefixes Page

View, add, remove and edit namespaces works

Changelog Page

Select graph and display write operations works
Operations shown in reverse chronological order
Detailed view of changed triples works
Restoring graph to a version works

Compare Page

Compare two graphs works

Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com> Signed-off-by: Finn Tarnowsky <finn.tarnowsky@soptim.de>

Commit the spec as a contract and generate the client offline from it

…cross builds Signed-off-by: Jan-Hendrik Spahn <jan-hendrik.spahn@soptim.de>

# Conflicts: # backend/src/main/java/org/rdfarchitect/api/controller/datasets/diagrams/CrossProfileDiagramIDRESTController.java # backend/src/main/java/org/rdfarchitect/api/controller/datasets/graphs/diagrams/CustomDiagramClassRESTController.java # backend/src/main/java/org/rdfarchitect/services/diagrams/CustomCustomDiagramService.java # backend/src/main/java/org/rdfarchitect/services/update/classes/UpdateClassService.java # backend/src/test/java/org/rdfarchitect/services/diagrams/CustomDiagramsServiceTest.java # frontend/package-lock.json # frontend/src/lib/api/apiDatasetUtils.js # frontend/src/lib/api/backend.js # frontend/src/lib/rendering/svelteflow/components/SvelteFlowPaneContextMenu.svelte # frontend/src/lib/rendering/svelteflow/svelteFlowWrapper.svelte # frontend/src/routes/GraphDeleteDialog.svelte # frontend/src/routes/ImportDialog.svelte # frontend/src/routes/NewClassDialog.svelte # frontend/src/routes/NewGraphDialog.svelte # frontend/src/routes/delete-relations-dialog/DeleteDependenciesDialog.svelte # frontend/src/routes/layout/menu-bar/Edit.svelte # frontend/src/routes/mainpage/classEditor/classEditor.svelte # frontend/src/routes/mainpage/classEditor/components/associations/save-association-to-backend.js # frontend/src/routes/mainpage/classEditor/components/enum-entries/save-enum-entry-to-backend.js # frontend/src/routes/mainpage/classEditor/fetch-class-editor-context.js # frontend/src/routes/mainpage/packageNavigation/DatasetSection.svelte # frontend/src/routes/mainpage/packageNavigation/PackageDeleteDialog.svelte # frontend/src/routes/mainpage/packageNavigation/build-nav-object.js # frontend/src/routes/mainpage/packageNavigation/custom-diagram-dialogs/CustomDiagramDeleteDialog.svelte # frontend/src/routes/mainpage/packageNavigation/custom-diagram-dialogs/RemoveFromDiagramDialog.svelte # frontend/src/routes/mainpage/packageNavigation/save-copy-class-to-backend.js

# Conflicts: # frontend/src/lib/api/backend.js # frontend/src/routes/NewClassDialog.svelte

spah-soptim

Re-review done.

Architecture is half-wired: the stores notify subscribers, but the UI still refreshes via forceReloadTrigger and versionControlStore.undo/redo hardcodes which stores to invalidate (misses datatypesStore/diagramStore resulting into stale caches after undo). Not worth fixing in this PR, but worth a follow up.

spah-soptim · 2026-07-17T09:36:30Z

    function pasteClass(copyAsAbstract, copyAttributes, copyAssociations) {
-        saveCopyClass(
+        classStore.saveCopyClass(
            editorState.selectedDataset.getValue(),
            editorState.selectedGraph.getValue(),
            selectedPackageDetails,


The menu-bar/shortcut paste is broken.
pasteClass calls classStore.saveCopyClass(dataset, graph, selectedPackageDetails, copyAsAbstract, ...) with 6 args, but the actual store method is pasteCopiedClasses(datasetName, graphURI, request).
It should call the wrapper in save-copy-class-to-backend.js (which has exactly this 6-arg signature) instead. The svelteflow context-menu paste path is fine.

spah-soptim · 2026-07-17T09:43:36Z

+        const { error, data } = await crossProfileStore.fetchRenderingData(
+            editorState.selectedDataset.getValue(),
+        );

-            const responseText = await res.text();
-            if (!responseText) {
-                displayDiagram = false;
-            } else {
-                response = JSON.parse(responseText);
-                renderingFormat = response.format;
-                displayDiagram = true;
-            }
-        } catch (error) {
-            console.error("Error fetching cross profile diagram data:", error);
+        if (error || !data) {
+            displayDiagram = false;
            response = null;
            renderingFormat = null;
-        } finally {
-            isLoading = false;
+        } else {
+            renderingFormat = response.format;
+            displayDiagram = true;
        }


fetchCrossProfileRenderingData destructures { error, data } but never assigns response = data (all the three other fetchers do).

spah-soptim · 2026-07-17T09:48:37Z

+                associationUUIDs.fromUUID,
+                associationUUIDs.toUUID,


save-association-to-backend.js:44 / AssociationEditorDialog.svelte:102
new associations get undefined UUIDs.

classStore.addAssociationPair returns an AssociationPairDto ({from: {...}, to: {...}}), but the dialog reads result.associationUUIDs.fromUUID/.toUUID. Only the replace path returns {fromUUID, toUUID}.

spah-soptim · 2026-07-17T09:49:58Z

-        const res = await bec.getOntology(
-            datasetNavEntry.label,
+        await ontologyStore.loadOntology(datasetNavEntry.id, graphNavEntry.id);
+        const { data } = await ontologyStore.getOntologyForGraph(


ontology is always undefined.
const { data } = await ontologyStore.getOntologyForGraph(...), but the store returns OntologyDto | null directly, not {data} (OntologyStore.ts:198-204). The {#if ontology} profile-header UI never renders.

spah-soptim · 2026-07-17T09:51:22Z

+        const { error } = versionControlStore.undo(
+            datasetNavEntry.id,
+            graphNavEntry.id,
+        );
+
+        if (!error) {
+            forceReloadTrigger.trigger();
+        }
    }

-    async function getOntology() {
-        const res = await bec.getOntology(
-            datasetNavEntry.label,
+    function redo() {
+        const { error } = versionControlStore.redo(


GraphSection.svelte:136,147

missing await on versionControlStore.undo/redo.

{ error } is destructured from a Promise, so error is always undefined and the reload fires unconditionally before the undo round-trip completes.

spah-soptim · 2026-07-17T10:14:09Z

+     * Generic loader for a slot in a graph's vocabulary. Caches data per
+     * (dataset, graph) and per slot, coalesces concurrent fetches.
+     */
+    async function loadSlot<K extends keyof GraphVocabulary>(


Store scaffolding is copy-pasted six times: the {data, fetchedAt, pending, error} slot type, makeKey with the :: separator, prefix-based invalidation, and the describeError→log→toast→return boilerplate.

DatatypesStore.loadSlot already is the generic helper - extracting it (plus a shared AsyncSlot) would remove the duplicated lines per store and make the :: key convention a single point of truth.

spah-soptim · 2026-07-17T10:19:08Z

+    function invalidateAll() {
+        update(() => ({ graphs: new Map() }));
+    }


The invalidateAll() and invalidateDataset() functions in all six stores have zero callers (except the graphStore.invalidateDataset). Worth a follow-up.

spah-soptim · 2026-07-17T10:22:43Z

+    }
+
+    // ---------- invalidation ----------
+    function invalidateDataset(datasetName: string) {


The DiagramStore.invalidateDataset also evicts all graph-diagram lists on dataset-diagram-only mutations. Could be fixed in a follow up. Nothing blocking.

spah-soptim · 2026-07-17T10:23:49Z

+    await loadXsdPrimitives();
+    await datatypesStore.loadForGraph(datasetName, graphUri);
+    const xsd = await getXSDPrimitives();


It awaits two independent fetches sequentially and redundantly re-reads getXSDPrimitives(). Could be worth a follow-up. Non blocking.

spah-soptim · 2026-07-17T10:25:19Z

@@ -144,7 +118,7 @@
    $effect(async () => {


duplicate readonly-recompute effect.

tarn-soptim force-pushed the chore/RDFA-483-central-frontend-store branch from b01166d to 092ef5a Compare May 28, 2026 10:55

spah-soptim changed the title ~~chore: rdfa 483 central frontend store~~ chore: central frontend store (RDFA-483) Jun 2, 2026

tarn-soptim force-pushed the chore/RDFA-483-central-frontend-store branch from 092ef5a to acf3557 Compare June 11, 2026 14:06

github-code-quality Bot found potential problems Jun 11, 2026

View reviewed changes

Comment thread frontend/src/lib/stores/GraphStore.ts Fixed

tarn-soptim and others added 11 commits June 24, 2026 10:37

datasetStore

9eebbfa

packageStore

4c16d13

readonly

9e3d88a

apply stores

35803c8

ontology Store

3308e7a

Template syntax in string literal

bb589db

Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com> Signed-off-by: Finn Tarnowsky <finn.tarnowsky@soptim.de>

use stores in frontend

379de4a

fix test and licenses

bf25d6f

ci: generate frontend API client from committed OpenAPI contract

b44545e

Commit the spec as a contract and generate the client offline from it

rebase

6e00c92

spotbugs

658b582

tarn-soptim force-pushed the chore/RDFA-483-central-frontend-store branch 2 times, most recently from 8c9e468 to 9105d54 Compare June 24, 2026 13:14

lint

e547afb

tarn-soptim force-pushed the chore/RDFA-483-central-frontend-store branch from 9105d54 to fdf5b8e Compare June 24, 2026 13:25

fix

b1e92a9

tarn-soptim force-pushed the chore/RDFA-483-central-frontend-store branch from fdf5b8e to b1e92a9 Compare June 24, 2026 13:29

fix(openapi): pin version to 0.0.0 in OpenAPI spec to prevent drift a…

2406fee

…cross builds Signed-off-by: Jan-Hendrik Spahn <jan-hendrik.spahn@soptim.de>

spah-soptim marked this pull request as ready for review June 25, 2026 11:45

Merge branch 'main' into chore/RDFA-483-central-frontend-store

8d31505

spah-soptim self-requested a review June 29, 2026 17:53

spah-soptim requested changes Jun 30, 2026

View reviewed changes

review changes

b1f78c9

spah-soptim changed the title ~~chore: central frontend store (RDFA-483)~~ feat: central frontend store (RDFA-483) Jul 7, 2026

spah-soptim added the enhancement New feature or request label Jul 7, 2026

review changes

ffc74c5

tarn-soptim added 8 commits July 9, 2026 11:42

rebase

1c5b803

rebase

28ae254

lint

bcf7b31

Merge branch 'main' into chore/RDFA-483-central-frontend-store

1c30989

# Conflicts: # frontend/src/lib/api/backend.js # frontend/src/routes/NewClassDialog.svelte

rebase

9bb25eb

fixes

63d66c2

lint

0a6c54e

spah-soptim requested changes Jul 17, 2026

View reviewed changes

Uh oh!

Conversation

tarn-soptim commented May 26, 2026

Description

Test Checklist

General Behavior

Global MenuBar

Welcome Page

Editor - MenuBar

Editor - Navigation

Editor - Package View

Editor - Class Editor

Prefixes Page

Changelog Page

Compare Page

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

spah-soptim left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants