Skip to content

design pages: Add completeUri to eidp example #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
eisenmann-b1 wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −1
Draft

design pages: Add completeUri to eidp example #99

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/design-pages/passwordless_gdm.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,8 @@ SSSD provides the available authentication mechanisms:
"role": "eidp",
"initPrompt": "Login",
"linkPrompt": "Log in online with another device",
"uri": "https://short.url.com/1234",
"completeUri": "https://short.url.com/login?code=1234",
"uri": "https://short.url.com/login",
"code": "1234",
"timeout": 300
}
Expand All @@ -277,6 +278,8 @@ SSSD provides the available authentication mechanisms:
}
}

**Note**: `completeUri` is optional; it will be empty if not supported by the IdP.
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The term "empty" can be ambiguous in a JSON context. It could mean an empty string (""), null, or that the key is omitted entirely. To make the documentation clearer for implementers, it's better to be specific. Assuming the key is omitted when not supported, the suggested change makes this explicit.

Suggested change
**Note**: `completeUri` is optional; it will be empty if not supported by the IdP.
**Note**: `completeUri` is optional and will be omitted if not supported by the IdP.


GDM replies with the selection:

.. code-block:: json
Expand Down