rewriting memcache tests by danlavu · Pull Request #8485 · SSSD/sssd

danlavu · 2026-02-27T07:57:40Z

No description provided.

gemini-code-assist

Code Review

This pull request is a significant refactoring of the memcache tests, aiming to reduce code duplication by introducing helper functions and parametrizing tests. While this is a great improvement for maintainability, the new implementation introduces several critical and high-severity issues, including a syntax error, flawed test logic that would cause failures, and several inconsistencies between test names, docstrings, and their implementations. I've detailed these issues in the review comments.

src/tests/system/tests/test_memcache.py

madhuriupadhye · 2026-03-11T07:23:52Z

@danlavu, can you please check,
ValueError: Required field 'customerscenario' is missing for 'tests/test_memcache.py::test_memcache__lookup_objects_by_name[users] (ldap)'

danlavu · 2026-03-12T01:18:05Z

@madhuriupadhye @andreboscatto I suggest reviewing this PR using the split diff view and not the unified diff.

andreboscatto · 2026-03-12T15:07:59Z

@madhuriupadhye @andreboscatto I suggest reviewing this PR using the split diff view and not the unified diff.

Indeed, I started reviewing the old document, understanding each case and looking at yours. Doing that side by side is helpful.

danlavu · 2026-03-13T16:52:35Z

@danlavu, can you please check, ValueError: Required field 'customerscenario' is missing for 'tests/test_memcache.py::test_memcache__lookup_objects_by_name[users] (ldap)'

fixed.

src/tests/system/tests/test_memcache.py

madhuriupadhye · 2026-03-16T12:03:04Z

src/tests/system/tests/test_memcache.py

+    Check the existence of objects, either users, groups, or initgroups.
+
+    This is a helper function to parameterize the memcache test. The assertions for each
+    cache time are different. Looking up 'users, will use 'id', groups will use 'getent group',


Please update to Looking up 'users', will use

cache time or cache type?

replace Looking up 'users, will use to Looking up **'users'**, will use

src/tests/system/tests/test_memcache.py

madhuriupadhye · 2026-03-16T12:25:38Z

please check,
ValueError: Number of steps and results do not match in idm-sssd-tc::tests/test_memcache.py::test_memcache__lookup_objects_by_id[users] (ldap)

289: 2: Group membership is correct -> 2. Group membership is correct

src/tests/system/tests/test_memcache.py

madhuriupadhye · 2026-03-31T12:26:59Z

src/tests/system/tests/test_memcache.py

-def test_memcache__invalidate_user_cache_after_stop(client: Client, provider: GenericProvider):
+@pytest.mark.parametrize(
+    "cache",
+    ["users", "groups", "initgroups", "all"],


assert_objects and assert_objects_not_found only handle "users", "groups", and "initgroups". There is no branch for cache == "all", so for "all" both functions return without asserting anything.
When cache is "all", those two lines invoke the helpers with "all", which matches none of the if cache == ... branches, so no assertions run there.

That is an awesome catch, thank you. Created a new test to cover all cache types disabled.

* parametrized test cases * added colliding hash test case * remove poor test scenarios

madhuriupadhye · 2026-04-02T07:20:00Z

src/tests/system/tests/test_memcache.py

-def test_memcache__invalidate_groups_cache_after_stop(client: Client, provider: GenericProvider):
+@pytest.mark.parametrize(
+    "cache",
+    ["users", "groups", "initgroups", "all"],


@pytest.mark.parametrize( "cache", ["users", "groups", "initgroups", "all"], ) ... assert_objects(client, objects, cache) invalidate_cache_stop_sssd(client, order, cache) assert_objects_not_found(client, objects, cache)

assert_objects / assert_objects_not_found only handle "users", "groups", and "initgroups". For "all" they do nothing, so those subtests do not assert warm-up or post-conditions. invalidate_cache_stop_sssd does hit cache_expire(everything=True) in the else branch, but the test body is still incomplete.

Drop "all" and add a dedicated test that loops the three cache kinds, or teach the helpers to treat "all" as “run all three branches.”, WDYT?

madhuriupadhye · 2026-04-02T07:22:08Z

src/tests/system/tests/test_memcache.py

-    gresult = client.tools.getent.group("group1")
-    assert gresult is not None, "Group group1 is not found using getent"
-    assert gresult.gid == 10001, f"Group gid {gresult.gid} is incorrect, 10001 expected"
+    colliding_user = client.host.conn.run(f"python {script}").stdout


Use something like colliding_user = client.host.conn.run(...).stdout.strip() and assert non-empty. A trailing newline can become part of the username and break lookups.

madhuriupadhye · 2026-04-02T07:29:48Z

src/tests/system/tests/test_memcache.py

+            assert result_user is not None, f"User '{user.name}' was not found!"
+            assert (
+                result_user.groups[-1].name == expected_groups[-1]
+            ), f"User '{user.name}' is member of incorrect groups!"


assert ( result_user.groups[-1].name == expected_groups[-1] ), f"User '{user.name}' is member of incorrect groups!"

This only compares the last group name. NSS/id group order may not match user_map list order. Safer: compare sets of names (or sorted lists) for user2 / user3.
Something like this,

assert result_user is not None, f"User '{user.name}' was not found!" expected_names = set(expected_groups) actual_names = {g.name for g in result_user.groups if g.name is not None} assert actual_names == expected_names, ( f"User '{user.name}' group names from id {sorted(actual_names)!r} " f"!= expected {sorted(expected_names)!r}" )

madhuriupadhye · 2026-04-02T07:31:30Z

src/tests/system/tests/test_memcache.py

-        assert result.user.name == user, f"Username {result.user.name} is incorrect, {user} expected"
-        assert result.user.id == id, f"User id {result.user.id} is incorrect, {id} expected"
+    The word objects is used because it may add 'users' or 'groups'. It returns a dict of lists of objects,
+    so they can be used to retrieve uidNUmber and gidNumbers.


Typo in docstrings: uidNUmber → uidNumber

madhuriupadhye · 2026-04-02T07:34:42Z

src/tests/system/tests/test_memcache.py

-    client.sssd.domain["ldap_id_mapping"] = "false"
+    script = client.fs.mktmp("""
+#!/usr/bin/env python3
+import argparse


argparse is imported but unused.

madhuriupadhye · 2026-04-02T07:35:37Z

src/tests/system/tests/test_memcache.py

-    assert client.tools.getent.group(202020) is None, "Group with gid 202020 was found which is not expected"
-
+    assert_objects_not_found(client, objects, cache)



PEP 8: Missing a blank line between functions at ~401–402.

madhuriupadhye · 2026-04-02T07:37:06Z

src/tests/system/tests/test_memcache.py

+    assert_objects_not_found(client, objects, cache)

 @pytest.mark.importance("critical")
-@pytest.mark.cache


None of these tests use @pytest.mark.cache, are we dropping this marker?

madhuriupadhye · 2026-04-02T07:43:51Z

Please make sure it will be green in IDM-CI also.

andreboscatto

Thanks, Dan! LGTM

danlavu added the Tests label Feb 27, 2026

danlavu marked this pull request as draft February 27, 2026 07:57

gemini-code-assist bot reviewed Feb 27, 2026

View reviewed changes

danlavu force-pushed the tests-rm-memcache branch from 88f67f3 to 4164a67 Compare February 28, 2026 10:43

github-advanced-security bot found potential problems Feb 28, 2026

View reviewed changes

src/tests/system/tests/test_memcache.py Fixed Show fixed Hide fixed

danlavu force-pushed the tests-rm-memcache branch from 4164a67 to 92e2433 Compare March 1, 2026 00:20

github-advanced-security bot found potential problems Mar 1, 2026

View reviewed changes

src/tests/system/tests/test_memcache.py Fixed Show fixed Hide fixed

danlavu force-pushed the tests-rm-memcache branch 4 times, most recently from 800149e to 79780ef Compare March 2, 2026 22:48

danlavu added the Waiting for review label Mar 2, 2026

danlavu force-pushed the tests-rm-memcache branch 2 times, most recently from 36e1b79 to 757722f Compare March 3, 2026 01:32

github-advanced-security bot found potential problems Mar 3, 2026

View reviewed changes

src/tests/system/tests/test_memcache.py Fixed Show fixed Hide fixed

src/tests/system/tests/test_memcache.py Fixed Show fixed Hide fixed

danlavu force-pushed the tests-rm-memcache branch 2 times, most recently from bc7b7a2 to b484bad Compare March 3, 2026 03:41

danlavu marked this pull request as ready for review March 3, 2026 04:33

danlavu added backport-to-sssd-2-11 backport-to-sssd-2-12 labels Mar 3, 2026

kopecmartin requested review from andreboscatto and madhuriupadhye March 4, 2026 13:42

kopecmartin assigned madhuriupadhye and andreboscatto Mar 4, 2026

madhuriupadhye added Changes requested and removed Waiting for review labels Mar 11, 2026

danlavu force-pushed the tests-rm-memcache branch from b484bad to 29ad9e3 Compare March 11, 2026 14:12

madhuriupadhye requested changes Mar 16, 2026

View reviewed changes

andreboscatto requested changes Mar 16, 2026

View reviewed changes

src/tests/system/tests/test_memcache.py Show resolved Hide resolved

src/tests/system/tests/test_memcache.py Show resolved Hide resolved

src/tests/system/tests/test_memcache.py Outdated Show resolved Hide resolved

src/tests/system/tests/test_memcache.py Outdated Show resolved Hide resolved

danlavu force-pushed the tests-rm-memcache branch 2 times, most recently from f45a3e2 to 3ab0a1e Compare March 17, 2026 05:24

danlavu force-pushed the tests-rm-memcache branch from 3ab0a1e to c3b49a7 Compare March 26, 2026 16:48

madhuriupadhye reviewed Mar 31, 2026

View reviewed changes

Dan Lavu added 2 commits April 1, 2026 13:36

Reworked memcache tests

23091c2

* parametrized test cases * added colliding hash test case * remove poor test scenarios

removing intg memcache tests

926a6b0

danlavu force-pushed the tests-rm-memcache branch from c3b49a7 to 926a6b0 Compare April 1, 2026 17:38

danlavu requested review from andreboscatto and madhuriupadhye April 1, 2026 17:39

madhuriupadhye reviewed Apr 2, 2026

View reviewed changes

andreboscatto approved these changes Apr 2, 2026

View reviewed changes

		assert client.tools.getent.group(202020) is None, "Group with gid 202020 was found which is not expected"

		assert_objects_not_found(client, objects, cache)

Conversation

danlavu commented Feb 27, 2026

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

madhuriupadhye commented Mar 11, 2026

Uh oh!

danlavu commented Mar 12, 2026

Uh oh!

andreboscatto commented Mar 12, 2026

Uh oh!

danlavu commented Mar 13, 2026

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

madhuriupadhye commented Mar 16, 2026 • edited by danlavu Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

madhuriupadhye Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

madhuriupadhye commented Apr 2, 2026

Uh oh!

andreboscatto left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

madhuriupadhye commented Mar 16, 2026 •

edited by danlavu

Loading

madhuriupadhye Mar 31, 2026 •

edited

Loading