Skip to content

krb5: make sure keytab is a FILE before checking for access #8556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
257 wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −9
Open

krb5: make sure keytab is a FILE before checking for access #8556

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions src/providers/krb5/krb5_keytab.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,16 +157,17 @@ krb5_error_code copy_keytab_into_memory(TALLOC_CTX *mem_ctx, krb5_context kctx,
}
kerr = 0;
goto done;
}

if (faccessat(AT_FDCWD, sep+1, R_OK, AT_EACCESS) != 0) {
saved_errno = errno;
DEBUG(SSSDBG_CRIT_FAILURE,
"keytab [%s] is not readable: [%d][%s].\n",
keytab_file, saved_errno, sss_strerror(saved_errno));
} else if ((strncmp(keytab_name, "DIR:", sizeof("DIR:") -1) == 0) ||
(strncmp(keytab_name, "FILE:", sizeof("FILE:") -1) == 0)) {
if (faccessat(AT_FDCWD, sep + 1, R_OK, AT_EACCESS) != 0) {
saved_errno = errno;
DEBUG(SSSDBG_CRIT_FAILURE,
"keytab [%s] is not readable: [%d][%s].\n",
keytab_file, saved_errno, sss_strerror(saved_errno));

kerr = KRB5KRB_ERR_GENERIC;
goto done;
kerr = KRB5KRB_ERR_GENERIC;
goto done;
}
}

kerr = sss_krb5_kt_have_content(kctx, keytab);
Expand Down
Loading