Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the system test requirements to use a personal fork of the pytest-mh library on a specific branch. Feedback indicates that referencing a personal fork and a branch name instead of a pinned commit SHA from an official repository poses a security risk and can lead to non-deterministic builds.
| git+https://github.com/next-actions/pytest-importance | ||
| git+https://github.com/next-actions/pytest-mh | ||
| #git+https://github.com/next-actions/pytest-mh | ||
| git+https://github.com/spoore1/pytest-mh@pylibssh_logging_fix |
There was a problem hiding this comment.
Referencing a personal fork and a branch name (spoore1/pytest-mh@pylibssh_logging_fix) instead of an official repository and a pinned commit SHA creates a security risk and potential for non-deterministic builds. Pin the dependency to a specific commit SHA.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
next-actions/pytest-mh#112