feat(docker): CLI owns alc via NuGet — drop VSIX-alc shim, set CONTINIA_ALC_CACHE - #5
Merged
Merged
Conversation
SShadowS
added a commit
that referenced
this pull request
Jul 13, 2026
feat(docker): CLI owns alc via NuGet — drop VSIX-alc shim, set CONTINIA_ALC_CACHE
SShadowS
added a commit
that referenced
this pull request
Aug 1, 2026
Review caught the first pass's sweep as incomplete while claiming completeness, and one deferral (table <th> contrast) had the "pre-existing convention" direction backwards. Both confirmed correct on re-check. Fixed 9 --color-text-muted selectors missed in round 1 (all measured 2.6-3.1:1, fail WCAG AA's 4.5:1; all now --color-text-secondary, 4.86-5.71:1, pass): - .integrity-panel__low-sample, .cost-panel__low-sample/.quality-panel__low-sample — the "Small sample: n=X ..." text, non-negotiable #5 in design-constraints.md. - .integrity-table th, .config-table th, .cost-table/.quality-table th, .operational-table th — re-checked dashboard.css at 8129ee0 (before this plan): the incumbent .plan-table/.telemetry-table/.tool-table headers all use --color-text-secondary and pass. These five NEW tables were the deviation, not the convention — my original deferral had this backwards. - .config-table__none — live-verified real AA failure (a <span> nested in a <td> gets its own colour, doesn't inherit the td's passing one). - .config-table__row--inert — live-verified with a real forced present-but-inert lever (PR_REVIEW_NO_POST=true): the declared muted colour never reaches the text (a more specific `.config-table td` rule wins), so this wasn't an active failure, but it was backwards regardless — this is the declared-but-silently-ignored-config row the whole plan is about, dimming it was never right. Fixed the source so declared intent matches (already-correct) rendering. - .config-panel__toggle-label — an earlier live check read the :hover override by accident (Playwright's cursor lingers post-click); the CSSOM rule and a hover-false re-check confirmed the resting style was really muted. Full before/after measurements and the corrected enumeration methodology are appended to task-10-report.md (overlay-local, not committed here). Claude-Session: https://claude.ai/code/session_01Ad8Q2RniB9y2dSbcCKDUad
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Container side of the AL toolchain redesign. The Continia CLI now provisions alc from NuGet itself, so the entrypoint stops building the
al->alcshim + PATH-prepending the VSIX alc (that path's stale alc was the infinite-exec-loop hang). Keeps AL_EXTENSION_PATH (LSP host still from the VSIX) and sets CONTINIA_ALC_CACHE=/state/tools/alc so the CLI caches the NuGet alc on the state volume.Proven e2e: fresh cache -> CLI downloads .Tools.Linux 18.0.37.11445-beta + compiles in 16s, no hang. Pairs with continia-cli feat/alc-nuget.