Skip to content

Restore Ubuntu build.sh CI by adapting SVFIR bindings to current SVF constant-var types#62

Closed
yuleisui with Copilot wants to merge 3 commits into
mainfrom
copilot/fix-failing-github-actions-job
Closed

Restore Ubuntu build.sh CI by adapting SVFIR bindings to current SVF constant-var types#62
yuleisui with Copilot wants to merge 3 commits into
mainfrom
copilot/fix-failing-github-actions-job

Conversation

Copilot AI commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

The Ubuntu Build via build.sh workflow fails because SVF-Python still binds ConstAggValVar / ConstAggObjVar, which are no longer present in current SVF. This PR updates the pybind layer to match upstream SVF types while preserving the existing Python-facing API names.

  • SVF API alignment (C++ bindings)

    • Replaced ConstAgg* C++ type checks/casts in pybind/SVFIR.cpp with ConstData* equivalents:
      • SVF::ConstAggValVarSVF::ConstDataValVar
      • SVF::ConstAggObjVarSVF::ConstDataObjVar
  • Python API compatibility

    • Kept legacy Python symbols by exporting aliases:
      • ConstAggValVar as alias of ConstDataValVar
      • ConstAggObjVar as alias of ConstDataObjVar
    • This preserves downstream imports/usages while tracking upstream SVF type changes.
  • Binding cleanup in touched paths

    • Removed invalid return_value_policy::reference usage on bool-returning helpers in the same compatibility block.
// Backward-compatible aliases in module exports
auto const_data_val_var = py::class_<SVF::ConstDataValVar, SVF::ValVar>(m, "ConstDataValVar");
m.attr("ConstAggValVar") = const_data_val_var;

auto const_data_obj_var = py::class_<SVF::ConstDataObjVar, SVF::BaseObjVar>(m, "ConstDataObjVar");
m.attr("ConstAggObjVar") = const_data_obj_var;

Copilot AI changed the title [WIP] Fix failing GitHub Actions job 'Build via build.sh on ubuntu-24.04' Restore Ubuntu build.sh CI by adapting SVFIR bindings to current SVF constant-var types Jul 16, 2026
Copilot AI requested a review from yuleisui July 16, 2026 11:44
@yuleisui yuleisui closed this Jul 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants