Fix stubtest (3.9) failure by removing non-existent ConstAgg bindings from API surface#63
Merged
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix the failing GitHub Actions job stubtest (3.9)
Fix stubtest (3.9) failure by removing non-existent ConstAgg bindings from API surface
Jul 16, 2026
yuleisui
marked this pull request as ready for review
July 16, 2026 11:35
There was a problem hiding this comment.
Pull request overview
This PR removes bindings and Python typing exports for ConstAggValVar / ConstAggObjVar to match the SVF types actually available in the svf-lib headers used by CI, resolving the stubtest (3.9) wheel-build failure caused by referencing non-existent symbols.
Changes:
- Removed
ConstAggValVar/ConstAggObjVarpybind classes and related downcast helpers frompybind/SVFIR.cpp. - Removed the same names from the public Python re-export surface in
pysvf/__init__.py. - Removed the corresponding types/members from
pysvf/pysvf.pyiand deleted the relatedstubtest_allowlist.txtentries.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| stubtest_allowlist.txt | Drops allowlist entries for the removed, non-existent symbols so stubtest no longer expects them. |
| pysvf/pysvf.pyi | Removes the ConstAgg* classes and their related is*/as* members from the typing surface. |
| pysvf/init.py | Stops re-exporting ConstAggValVar / ConstAggObjVar from the package top-level API. |
| pybind/SVFIR.cpp | Removes pybind registrations and cast helpers that referenced unavailable SVF symbols. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
stubtest (3.9)workflow was failing in the wheel build step because the bindings referencedSVF::ConstAggValVarandSVF::ConstAggObjVar, which are not present in thesvf-libheaders used in CI. This change aligns the C++ bindings and Python typing surface with the actual exported SVF types.Root-cause alignment (C++ pybind layer)
ConstAggValVar/ConstAggObjVarbindings and cast helpers frompybind/SVFIR.cpp.Public Python API consistency
ConstAggValVarandConstAggObjVarre-exports frompysvf/__init__.py.Typing + stubtest consistency
pysvf/pysvf.pyi.stubtest_allowlist.txtfor the same symbols.