Skip to content

Double up GEP edges in graph output#1874

Merged
yuleisui merged 2 commits into
SVF-tools:masterfrom
mbarbar:purple
Jul 22, 2026
Merged

Double up GEP edges in graph output#1874
yuleisui merged 2 commits into
SVF-tools:masterfrom
mbarbar:purple

Conversation

@mbarbar

@mbarbar mbarbar commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

I have trouble differentiating the purple from blue, especially when zoomed out.
image
image
Left is old, right is new.

@codecov

codecov Bot commented Jul 21, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.82%. Comparing base (ef21931) to head (d9c5258).
⚠️ Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
svf/lib/Graphs/CFLGraph.cpp 0.00% 2 Missing ⚠️
svf/lib/Graphs/ConsG.cpp 0.00% 1 Missing ⚠️
svf/lib/Graphs/IRGraph.cpp 0.00% 1 Missing ⚠️
svf/lib/Graphs/VFG.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1874   +/-   ##
=======================================
  Coverage   65.82%   65.82%           
=======================================
  Files         251      251           
  Lines       24665    24668    +3     
  Branches     4661     4662    +1     
=======================================
+ Hits        16235    16238    +3     
  Misses       8430     8430           
Files with missing lines Coverage Δ
svf/lib/Graphs/SVFG.cpp 72.30% <100.00%> (ø)
svf/lib/Graphs/ConsG.cpp 64.51% <0.00%> (ø)
svf/lib/Graphs/IRGraph.cpp 44.50% <0.00%> (ø)
svf/lib/Graphs/VFG.cpp 50.98% <0.00%> (ø)
svf/lib/Graphs/CFLGraph.cpp 30.76% <0.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yuleisui

Copy link
Copy Markdown
Collaborator

The current colour is a little too light and, unfortunately, appears almost black to me.

Could we make your purple a bit darker, or distinguish the arrow in another way, such as by changing its decoration or shape?

@mbarbar

mbarbar commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator Author

How about double lines?
image
Dashed and dotted are used for other things, so I thought best not to use that.

@mbarbar mbarbar changed the title Change shade of purple in graphs Double up GEP edges in graph output Jul 22, 2026
@yuleisui
yuleisui merged commit 14746d2 into SVF-tools:master Jul 22, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants