Repository navigation
fix: widen Circle x402 user-wallet authorization window - #110
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
oneshot | ba0afd4 | Sep 12 2026, 10:24 PM |
Collaborator
|
WW |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Widen the Circle Gateway user-wallet authorization window so human wallet approval is not rejected as too short. Strict payer, recipient, amount, asset, network, nonce, and validity checks remain enforced. Explicit pre-settlement
Payment verification failedresponses becomeFAILED_SAFE; ambiguous outcomes remainUNKNOWN.The branch is synced with the latest
develop, using its newer Privy implementation while retaining the shared validity-window constant and Circle adapter changes.Scope and acceptance criteria
validBeforeis accepted; values beyond the bound are rejected before forwarding.FAILED_SAFE.UNKNOWN.developimplementation is retained; no unrelated cleanup is included.Product and security invariants
Invariant notes: the candidate delta is limited to web, contracts, supplier-adapter, tests, and context. Server, storage, and worker trees are unchanged from
develop; PostgreSQL-gated tests are not applicable to this delta.Validation
Independent review evidence
Gate A — exact candidate tree before push
Base commit SHA:
fd515729ddba8516073ac598cf588bedb9291500Candidate tree SHA:
bc01869a0e7e844c8a11ba44b94ea939444a995dCandidate commit SHA:
ba0afd496161466edc1a3f2f8d439c13158a2673Reviewer tool:
free-pi-cliReviewer model:
deepseek-v4-flashVerdict:
VERDICT: PASSFindings: no blocking findings. Non-blocking risks are documented in the reviewer verdict.
The reviewed tree equals the committed tree.
Gate B — exact remote PR head
Pull request URL/number: fix: widen Circle x402 user-wallet authorization window #110
Remote head commit SHA:
ba0afd496161466edc1a3f2f8d439c13158a2673Remote head tree SHA:
bc01869a0e7e844c8a11ba44b94ea939444a995dReviewer tool:
free-pi-cliReviewer model: pending Gate B
Verdict: pending Gate B
Findings or residual risks: pending Gate B
Gate B reviewed the current remote head and matches Gate A's approved tree, or a fresh Gate A was run for the changed tree.
Agent policy / repository-policy and all applicable CI checks pass.
Risk and rollback
Human merge