Skip to content

fix(web): resume supplier results and copy wallet address - #134

Merged
SuPuHe merged 1 commit into
developfrom
fix/session-details-resume-result
Sep 13, 2026
Merged

SuPuHe merged 1 commit into
developfrom
fix/session-details-resume-result

Conversation

@SuPuHe

@SuPuHe SuPuHe commented Sep 13, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Add a dedicated wallet-address copy action and align the wallet address styling with the session DID.
  • Handle the asynchronous supplier-result response from POST /v1/jobs/:jobId/resume without creating repeated job-list requests.
  • Refresh the job list once after the queued resume, then render the stored supplier result when it is available.
  • Preserve the no-new-payment recovery path and add regression coverage.

Scope and acceptance criteria

  • The change is limited to the session-details and resumable-result fixes.
  • Wallet address is separated, styled like the DID, and copied in full.
  • Resume sends exactly one POST /v1/jobs/:jobId/resume.
  • A 202/PENDING resume response receives one delayed GET /v1/jobs refresh, with no repeated polling loop.
  • The resume flow does not call /v1/jobs/:jobId/user-wallet/submit.
  • When the refreshed job contains a result, the UI renders Result ready and the supplier report.
  • No second payment or settlement action is introduced.
  • No unrelated cleanup is included.

Product and security invariants

  • No settlement or payment path was changed.
  • Resume only observes durable job state and preserves the no-new-payment guarantee.
  • No secret, token, production identifier, or personal data is committed or included in review evidence.

Validation

pnpm format:check - PASS
pnpm --filter @oneshot/web lint - PASS
pnpm --filter @oneshot/web typecheck - PASS
pnpm --filter @oneshot/web test - PASS (17 files, 95 tests)
pnpm --filter @oneshot/web test:browser - PASS (8 tests)
git diff --cached --check - PASS

Independent review evidence

Gate A

  • Verdict: VERDICT: PASS
  • Reviewer tool: free-pi-cli
  • Reviewer model: deepseek-v4-flash
  • Reviewed base: develop (d671af1da36878b7aaafcfc3049bc958e0daeb34)
  • Reviewed target: fix/session-details-resume-result, staged workspace
  • Reviewed tree: 69cf1c3f24861c155f9143aec0e1b6bf5958c0db
  • Blocking findings: None reported
  • Non-blocking findings: None reported with the supplied verdict

Gate B

  • Verdict: NOT RUN — intentionally deferred per user request.

Risk and rollback

  • Residual risk: If the supplier is still pending after the single follow-up refresh, the user can use the existing refresh action to check again.
  • Rollback: Revert commit 26dfab5989f39c111d22f626b69a3b38d17a197e; no payment or settlement data migrations are involved.

Human merge

  • A human owner has reviewed the evidence and will perform the merge.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
oneshot 6be9c33 Sep 13 2026, 12:21 PM

@SuPuHe
SuPuHe marked this pull request as ready for review September 13, 2026 12:23
@SuPuHe
SuPuHe merged commit 266b6a7 into develop Sep 13, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant