Repository navigation
feat(worker): atomic at-most-once settlement worker (A03) - #18
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ❌ Deployment failed View logs |
oneshot | 7eb82d5 | Sep 07 2026, 03:36 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Milestone A03 — Atomic At-Most-Once Worker (
milestones/coder-a/A03-atomic-worker.md):claimSubmission(READY -> SUBMITTING) committing transaction before calling external settlement port.completeSubmission: persists confirmed settlements toCOMMITTED, terminal failures toFAILED_SAFE, and uncertainty/timeout outcomes toUNKNOWNwith enqueued reconciliation job.@oneshot/workerpackage (apps/worker) with dual runner modes: Graphile WorkerTaskList(createTaskList) and PostgreSQL transactional outbox draining (drainOutboxJobswithFOR UPDATE SKIP LOCKED).003_worker_jobs.sqladdingsubmit_settlementtask identifier.apps/worker/test/child-worker-process.mjs).Scope and acceptance criteria
Product and security invariants
Invariant notes:
claimSubmissionand unique constraint on settlements table.UNKNOWNand enqueue reconciliation work instead of retry.Validation
Commands and results:
Independent review evidence
Gate A — exact candidate tree before push
Base commit SHA:
64d0a6fb65c3bedce169cc95867595e3f79b90c7Candidate tree SHA:
5c1bc4f7101ad5fd796027dc220df5c25a5927cdCandidate commit SHA:
7eb82d5009d2e7db8213d60ed38639dfc7a17a28Reviewer tool:
free-pi-cliReviewer model:
glm 5.3Verdict:
VERDICT: PASSFindings or residual risks: None
The reviewed tree equals the committed tree.
Gate B — exact remote PR head
Pull request URL/number: feat(worker): atomic at-most-once settlement worker (A03) #18
Remote head commit SHA:
7eb82d5009d2e7db8213d60ed38639dfc7a17a28Remote head tree SHA:
5c1bc4f7101ad5fd796027dc220df5c25a5927cdReviewer tool:
free-pi-cliReviewer model:
glm 5.3Verdict:
VERDICT: PASSFindings or residual risks: None
Gate B reviewed the current remote head and matches Gate A's approved tree, or a fresh Gate A was run for the changed tree.
Agent policy / repository-policyand all applicable CI checks pass.Risk and rollback