Repository navigation
feat(reconciliation): implement live Vertex AI recovery advisor and Subgraph MCP client - #46
Merged
Merged
Conversation
…ubgraph MCP client
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
oneshot | 1e812d4 | Sep 08 2026, 11:54 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implement live
VertexAiRecoveryAdvisorandLiveSubgraphMcpRecoveryPortfor AI-assisted candidate recovery and lost-hash discovery, and integrate both into worker composition.Scope and acceptance criteria
VertexAiRecoveryAdvisorinpackages/reconciliation/src/vertex-advisor.tsconforming toRecoveryAdvisorPortandvalidateAndNormalizeRecommendation.LiveSubgraphMcpRecoveryPortinpackages/reconciliation/src/subgraph-mcp-client.tssupporting both MCP JSON-RPC protocol (execute_query_by_deployment_id) and Graph Gateway fallback with MCP envelope normalization.@oneshot/reconciliation.apps/workercomposition with zero external submission permissions (settlementPermission: 'NEVER').Product and security invariants
Invariant notes:
Recovery LLM advisor and Subgraph MCP have zero signing, retry, or settlement permissions (
settlementPermission: 'NEVER'). All advisory outputs are strictly verified against authoritative Arc receipts by the OneShot deterministic safety core.Validation
Commands and results:
Independent review evidence
Gate A — exact candidate tree before push
Base commit SHA: 97e56b5
Candidate tree SHA: d677f01c5b86ff30b35766916fe70da5685a3cf1
Candidate commit SHA: 1e812d4
Reviewer tool:
free-pi-cliReviewer model:
glm-5.3-flashVerdict:
VERDICT: PASSFindings or residual risks: no blockers; missing outbound timeouts (read-only advisory/discovery path); zero-submission assertion could be explicit on stored pack in composition test.
The reviewed tree equals the committed tree.
Gate B — exact remote PR head
Pull request URL/number: feat(reconciliation): implement live Vertex AI recovery advisor and Subgraph MCP client #46 (feat(reconciliation): implement live Vertex AI recovery advisor and Subgraph MCP client #46)
Remote head commit SHA: 1e812d4
Remote head tree SHA: d677f01c5b86ff30b35766916fe70da5685a3cf1
Reviewer tool:
free-pi-cliReviewer model:
glm-5.3-flashVerdict:
VERDICT: PASSFindings or residual risks: no blockers; missing outbound timeouts on fetch (read-only advisory/discovery path); zero-submission assertion could be explicit on stored pack in composition test.
Gate B reviewed the current remote head and matches Gate A's approved tree.
Agent policy / repository-policyand all applicable CI checks pass.Risk and rollback
Human merge