Repository navigation
fix(recovery): allow delivered reconciliation retries - #66
Merged
Merged
Conversation
kapustazh
marked this pull request as ready for review
September 10, 2026 15:54
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
oneshot | 206ad43 | Sep 10 2026, 03:48 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow a later read-only reconciliation job after the prior reconcile job is delivered. Preserve one pending manual retry under concurrent API calls.
Scope and acceptance criteria
Product and security invariants
Invariant notes:
The change only inserts
reconcile_intentoutbox work. It does not mutate intent authority, submit settlement, or weaken the one-intent/at-most-one-settlement invariant. Recovery remains read-only withsettlementPermission: NEVER.Validation
Commands and results:
Independent review evidence
Gate A — exact candidate tree before push
Base commit SHA:
95709a8256a11f2c544b1d406e906ba8ea2d7867Candidate tree SHA:
4ea5bf3afef36288299fb84cf4da49ed1cc62844Candidate commit SHA:
206ad437da5fb3a059ea21723d2de8f27da907b7Reviewer tool:
free-pi-cliReviewer model:
deepseek-v4-flashVerdict:
VERDICT: PASSFindings or residual risks: Count-derived generation fails closed if outbox rows are ever purged; no purge path exists. Exact PostgreSQL concurrency behavior is CI-gated.
The reviewed tree equals the committed tree.
Gate B — exact remote PR head
Pull request URL/number: fix(recovery): allow delivered reconciliation retries #66
Remote head commit SHA:
206ad437da5fb3a059ea21723d2de8f27da907b7Remote head tree SHA:
4ea5bf3afef36288299fb84cf4da49ed1cc62844Reviewer tool:
free-pi-cliReviewer model:
deepseek-v4-flashVerdict:
VERDICT: PASSFindings or residual risks: Count-derived generation remains fail-closed if future outbox purging is added; no purge path exists.
Gate B reviewed the current remote head and matches Gate A's approved tree, or a fresh Gate A was run for the changed tree.
Agent policy / repository-policyand all applicable CI checks pass.Risk and rollback
206ad437da5fb3a059ea21723d2de8f27da907b7; existing fail-closed one-job-per-version behavior returns.Human merge