Fix DM notifications, encrypted events, and enable reaction notifications#178
Merged
7w1 merged 3 commits intoSableClient:devfrom Mar 12, 2026
Merged
Conversation
Just-Insane
force-pushed
the
feat/notification-improvements
branch
from
a8bcb35 to
a9757ba
Compare
Just-Insane
changed the title
Just-Insane
force-pushed
the
feat/notification-improvements
branch
from
7ce32e2 to
7b8622b
Compare
Just-Insane
changed the title
Just-Insane
force-pushed
the
feat/notification-improvements
branch
from
d0d4c9a to
2e85725
Compare
- Fix DM notifications using multiple detection signals (m.direct + member count heuristic) - Fix encrypted event handling with proper event type checking and decryption - Use fixupNotifications() to reconcile Sliding Sync notification count drift - Force DM notifications for all messages (excluding mute/mentions-only settings) - Implement robust stale count detection and correction for accurate badge numbers - Add timeline walking fallback for computing real counts when SDK counters are stale - Improve notification type detection for DMs with proper mute checks - Show in-app banner for background account notifications when app is visible - Add sound notifications for all accounts (active and background) - Always force reaction notifications to show for all room types - Improve background notification routing - build payload first, then route by visibility Known Issues: - Background account notifications: System/push notifications do not work when app is hidden - Mobile keyboard banner positioning: Banner not properly positioned when keyboard is open on iOS
Just-Insane
force-pushed
the
feat/notification-improvements
branch
from
986c6b4 to
976d2e8
Compare
Contributor
|
Wow, nice work! |
Contributor
Author
|
Found a bug in the reactions code - we notify for all reactions, not just reactions on your own messages. Will fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes several notification issues and adds support for encrypted event and reaction notifications:
DM Notification Detection
m.directaccount data instead of push rules - Fixes Sliding sync breaks notifications #48Badge Counting
Encrypted Event Notifications
MatrixEventEvent.Decryptedfor proper encrypted event notificationsReaction Notifications
m.reactionto notification event typesUI Improvements
Known Issues