Parse and process Steam AppIDs and DepotIDs#934
Parse and process Steam AppIDs and DepotIDs#934HeroponRikiBestest wants to merge 6 commits intoSabreTools:masterfrom
Conversation
MPF.Frontend/Tools/PhysicalTool.cs
Outdated
| /// </summary> | ||
| /// <param name="drive">Drive to extract information from</param> | ||
| /// <returns>Steam2 information on success, null otherwise</returns> | ||
| public static string? GetSteam2Info(Drive? drive) |
There was a problem hiding this comment.
All 3 steam methods contain a lot of duplicated code. Would you prefer me to create helper methods, or would that be out of line for the style of PhysicalTool.cs?
|
|
||
| // ? needed due to note in note in https://learn.microsoft.com/en-us/dotnet/api/system.io.directory.getfiles | ||
| #if NETFRAMEWORK | ||
| string[] sisPaths = Directory.GetFiles(drive.Name, "?*.sis", SearchOption.AllDirectories); |
There was a problem hiding this comment.
Is there any non-annoying way to recurse in netframework?
| if (upper["depots"] == null) | ||
| continue; | ||
|
|
||
| var depotArr = upper["depots"]?.ToObject<Dictionary<string, string>>(); |
There was a problem hiding this comment.
Do you have any idea why I still need to use conditional access on upper["depots"] even though I did upper["depots"] == null just above?
|
PR is ready for review. Let me know if there's anything I still need to do, this should be fully complete. (Aside from waiting on the Serialization and Redumplib PRs. To be clear, I've already tested locally with both of them hooked up.) |
HeroponRikiBestest
force-pushed
the
steam
branch
from
3076968 to
f9976b9
Compare
|
Closing because I cannot merge properly. |
2 participants
Waiting on SabreTools/SabreTools.RedumpLib#13, plus everything that PR is waiting on, plus the same requirements for this PR.