Update Jakarta README.md - Remove the check dependency on ping.#54
Open
arturmartins wants to merge 1 commit into
Open
Update Jakarta README.md - Remove the check dependency on ping.#54arturmartins wants to merge 1 commit into
arturmartins wants to merge 1 commit into
Conversation
Remove the check dependency on ping.
|
hi, wondering if we can merge this and enable the check button for Jakarta? as a new user it was surprising the check button didn't work for this scenario, and this seems like a nice fix, worked as expected in my own solution vm. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of using
pingto test the system's standard DNS resolution process, I propose usinggetentinstead since it doesn't require communication with the outside world.The
getentcommand with thehostsargument utilises the system's libc resolver to perform name lookups based on the configuration specified in/etc/nsswitch.conf. This approach ensures the testing of the system's actual name resolution pathway, as would be used by most applications and tools on the system that rely on DNS resolution.I tested the script in the Jakarta VM and it worked as expected.