Skip to content

Fix(#97): wardNickname → wardName 통일 및 nickname 컬럼 정리 - #98

Merged
ch0412 merged 1 commit into
developfrom
fix/97-ward-nickname-null
Aug 11, 2026
Merged

Fix(#97): wardNickname → wardName 통일 및 nickname 컬럼 정리#98
ch0412 merged 1 commit into
developfrom
fix/97-ward-nickname-null

Conversation

@ch0412

@ch0412 ch0412 commented Aug 11, 2026

Copy link
Copy Markdown
Member

🎯 개요

wardNickname이 항상 null로 내려오는 버그 수정 및 nickname 컬럼 정리

✅ 작업 내용

  • FamilyMemberResponse wardNickname → wardName 필드명 변경
  • getNickname() → getName() 수정
  • User 엔티티 nickname 필드 제거
  • Flyway V20: users 테이블 nickname 컬럼 드롭

🧪 테스트 결과

  • ./gradlew build -x test 통과

🔗 관련 이슈

Closes #97

✅ 체크리스트

  • 관련 이슈를 연결했습니다.
  • 구현 범위와 변경 이유를 설명했습니다.
  • 로컬 테스트를 통과했습니다.
  • API 변경 사항을 Swagger에 반영했습니다.
  • DB 변경 사항과 마이그레이션을 포함했습니다.
  • 민감 정보가 코드·로그·테스트 데이터에 포함되지 않았습니다.
  • 프론트엔드에 영향을 주는 응답 스키마 또는 Enum 변경을 공유했습니다.
  • 병합 전 작업 브랜치를 삭제하지 않았습니다.

Summary by CodeRabbit

  • Changes
    • Family member information now displays the ward’s name instead of a nickname.
    • Removed support for user nicknames from the system and database.

@ch0412 ch0412 self-assigned this Aug 11, 2026
@ch0412 ch0412 added the fix Bug fixes label Aug 11, 2026
@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 8a202030-3cb0-475b-9d5b-0c16c436fb27

📥 Commits

Reviewing files that changed from the base of the PR and between 5416dcc and af44a6d.

📒 Files selected for processing (3)
  • src/main/java/com/gold/safefam/domain/family/dto/FamilyMemberResponse.java
  • src/main/java/com/gold/safefam/domain/user/entity/User.java
  • src/main/resources/db/migration/V20__drop_users_nickname_column.sql
💤 Files with no reviewable changes (1)
  • src/main/java/com/gold/safefam/domain/user/entity/User.java

📝 Walkthrough

Walkthrough

The family member response now returns the ward name. The User entity no longer maps a nickname. Migration V20 removes the nickname column from users.

Changes

Ward name and nickname removal

Layer / File(s) Summary
Family member response field and mapping
src/main/java/com/gold/safefam/domain/family/dto/FamilyMemberResponse.java
Renames wardNickname to wardName and maps the response from FamilyLink.getWard().getName().
User nickname schema removal
src/main/java/com/gold/safefam/domain/user/entity/User.java, src/main/resources/db/migration/V20__drop_users_nickname_column.sql
Removes the nickname property and adds a migration to drop users.nickname.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning The backend changes meet the API and database objectives, but no web or app changes are included for issue #97. Add the required web and app changes from wardNickname to wardName, or link evidence that those changes are included elsewhere.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes renaming wardNickname to wardName and removing the nickname column.
Out of Scope Changes check ✅ Passed All changed files directly support the wardName rename and nickname column removal objectives in issue #97.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/97-ward-nickname-null

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ch0412
ch0412 merged commit def722b into develop Aug 11, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Fix] wardNickname → wardName 통일 및 nickname 컬럼 정리

1 participant