Improve GitHub Actions workflows based on zizmor static analysis#161
Merged
Conversation
Added empty `permissions: {}` blocks to all workflows to prevent
unintended/unexpected default permissions from leaking in. This was a
recommendation from the zizmor auditor persona. This change aligns the
workflows with the latest recommendations for fine-grained permissions
configuration.
douglatornell
added
maintenance
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #161 +/- ##
=======================================
Coverage 92.00% 92.00%
=======================================
Files 15 15
Lines 2339 2339
Branches 126 126
=======================================
Hits 2152 2152
Misses 172 172
Partials 15 15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Added descriptive comments to all GitHub Actions workflow permission blocks to clarify the specific purpose for each permission. This improves workflow readability and aids in future maintenance and auditing efforts.
Updated the `name` field in all GitHub Actions workflows to provide better clarity about the purpose of each job. This aids maintainability and improves the readability of workflow definitions and the GitHub Actions UI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zizmorto ignore unpinned uses of our own reusable workflows