Make non-Dropbox Store callback consistently async

[Copilot]

The non-Dropbox path in Store called callback.call(this) synchronously, creating a timing hazard: callers assigning the Store instance to a variable used inside the callback could observe undefined before the assignment completed.

Change

Wrapped the non-Dropbox callback in setTimeout(..., 0) to match the existing async behavior of the Dropbox path:

// Before
} else if (callback) {
    callback.call(this);
}

// After
} else if (callback) {
    setTimeout(function () {
        callback.call(self);
    }, 0);
}

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

[Copilot]

Pull request overview

This PR fixes a timing hazard in Store.js where the non-Dropbox initialization path called the user-provided callback synchronously. Because callers (e.g., LetterStructure.js, Settings.js) reference the returned Store instance inside the callback, calling back synchronously meant that variable assignment (e.g., var store = new dataStore(...)) had not yet completed when the callback fired, potentially exposing undefined. The fix wraps the non-Dropbox callback in setTimeout(..., 0) to match the Dropbox path's existing async behavior.

Changes:

• Wrapped the non-Dropbox callback.call(this) in a setTimeout closure using self (consistent with var self = this defined at the top of the constructor) to make it asynchronous.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.