Skip to content

Extract pure helpers from LetterStructure.js and test actual production code#6

Merged
Samuel3 merged 5 commits into
feature/add-testsfrom
copilot/sub-pr-5
Mar 2, 2026
Merged

Extract pure helpers from LetterStructure.js and test actual production code#6
Samuel3 merged 5 commits into
feature/add-testsfrom
copilot/sub-pr-5

Conversation

Copilot AI commented Feb 28, 2026

Copy link
Copy Markdown
Contributor
  • Analyze CI failure: npm ci failing with "Missing from lock file" errors
  • Root cause: previous session ran npm install which upgraded package-lock.json and app/package-lock.json from lockfileVersion 1 to lockfileVersion 3
  • Restore both lock files to their original lockfileVersion 1 content (matching feature/add-tests base branch)
  • Restore deleted getCurrentContent structure tests to letterStructure.test.js
  • Confirm all tests pass (47 passing)

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

Copilot AI and others added 2 commits February 28, 2026 20:15
Co-authored-by: Samuel3 <15921086+Samuel3@users.noreply.github.com>
…on code

Co-authored-by: Samuel3 <15921086+Samuel3@users.noreply.github.com>
Copilot AI changed the title [WIP] Address feedback on testing improvements from PR #5 review Extract pure helpers from LetterStructure.js and test actual production code Feb 28, 2026
@Samuel3

Samuel3 commented Mar 1, 2026

Copy link
Copy Markdown
Owner

@copilot Please fix broken build

Co-authored-by: Samuel3 <15921086+Samuel3@users.noreply.github.com>

Copilot AI commented Mar 1, 2026

Copy link
Copy Markdown
Contributor Author

@copilot Please fix broken build

Fixed in commit d544b68. The CI failure was caused by accidentally committing updated package-lock.json files — a previous npm install run upgraded them from lockfileVersion 1 to lockfileVersion 3, which caused npm ci to report packages as missing. Both package-lock.json and app/package-lock.json have been restored to their original lockfileVersion 1 content (matching the feature/add-tests base branch), since the code changes don't require any new packages.

Comment thread test/letterStructure.test.js
Co-authored-by: Samuel3 <15921086+Samuel3@users.noreply.github.com>
@Samuel3 Samuel3 marked this pull request as ready for review March 2, 2026 19:31
@Samuel3 Samuel3 merged commit a893263 into feature/add-tests Mar 2, 2026
2 checks passed
@Samuel3 Samuel3 deleted the copilot/sub-pr-5 branch March 2, 2026 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants