Player manager and UI improvements by emyhrberg · Pull Request #158 · ScalarVector1/DragonLens

emyhrberg · 2026-05-10T05:05:59Z

Adds the new Player Manager (Browser) with new buttons:

go to button to teleport to a player
bring here button to bring a player to you
freeze button to freeze a player
shows additional stats for players and new filters and drawing options
a new grid and list mode toggle for player manager

UI interaction improvements

Now draws a highlight of the tool when opening a tool's window (DraggableUIStates,Tool,etc)
Added so panels being dragged are always ordered on top by updating UILoader
Added so panels cant be clicked if they are below other panels by updating UILoader.UpdateUI()
Hide tooltips if hovering another panel with SmartUIElement.CanShowTooltip and UILoader.CanShowTooltip

Misc:

Added custom noclip shift speeds
Fixed StyledScrollbar so you can drag it
Fixed ToggleButton to use Asset instead of a string path
Added better grid list toggle to Browser

Demo

dladmin now works properly. 👍

- Fix: Remove welcome text for non-admins - Fix: Remove toolbars from the map for non-admins - Fix: Remove first time setup for non-admins - Fix: Handle silent exception: index out of range in BuffSpawner receivepacket() better and safer - Fix: FastForward. Packet underflow is still happening but no visual bugs yet

Player manager improvements: - Added new buttons, filters, stats, and custom UI! UI interaction improvements - Now draws a highlight of the tool when opening a tool's window (DraggableUIStates,Tool,etc) - Added so panels being dragged are always ordered on top by updating UILoader - Added so panels cant be clicked if they are below other panels by updating UILoader.UpdateUI() - Hide tooltips if hovering another panel with SmartUIElement.CanShowTooltip and UILoader.CanShowTooltip Misc: - Added custom noclip shift speeds - Fixed StyledScrollbar so you can drag it - Fixed ToggleButton to use Asset<texture2D> instead of a string path - Added better grid list toggle to Browser

ScalarVector1

Done my best to review the general UI changes, will take a look at the player management UI in either a seperate review or if made a seperate PR there, this is quite alot of changes in one PR regardless.

Couple of things to address here potentially, overall conceptually the UI changes I find are all positive, mostly just a couple of implementation nits

ScalarVector1 · 2026-05-20T16:03:11Z

+			//Main.NewText(filter);
+
+			// Special toggle filter.
+			if (filter is ButtonOptionFilter buttonToggle)


Why are these specific checks needed here exactly? This seems to be an impractical implementation that will continually grow for more filter types. Im unsure why these need to occur here to start?

ScalarVector1 · 2026-05-20T16:06:51Z

 			// This logic exists because this dragger is always present, not just when customizing. Has to be done due to
 			// append order effecting click priority :/
-			if (!CustomizeTool.customizing)
+			if (!CustomizeTool.customizing && CanShowTooltip)


why is this a condition here? This seems counterintuitive

ScalarVector1 · 2026-05-20T16:07:50Z

+
+			if (Main.netMode != NetmodeID.SinglePlayer && !PermissionHandler.CanUseTools(Main.LocalPlayer))
+			{
+				return;


Do we truly want to completely hide the UI in the instance that a player does not have permissions? Are there some tools that potentially we still need to allow or could exist in the future?

We should note this isn't any sort of security, tools can still be triggered by hotkey

ScalarVector1 · 2026-05-20T16:10:12Z

+			}
+
+			Tooltip tooltip = UILoader.GetUIState<Tooltip>();
+			if (tooltip != null && tooltip.Visible)


Is there a reason these extra external visible checks need to occur here?

ScalarVector1 · 2026-05-20T16:11:33Z


+		public override void Unload()
+		{
+			Terraria.On_Main.DoUpdate -= UpdateExtraTimes;


this is uneccisary in modern tModLoader

ScalarVector1 · 2026-05-20T19:42:57Z


+			if (type <= 0 || type >= BuffLoader.BuffCount)
+			{
+				ModLoader.GetMod("DragonLens").Logger.Warn(


You should be able to simply use the Mod property of ModType here rather than GetMod

ScalarVector1 · 2026-05-20T19:44:16Z

 #if DEBUG
-			if (Main.netMode == NetmodeID.Server)
-				Mod.Logger.Info($"Sending packet for tool {DisplayName} ({Name}) from server");
+			//if (Main.netMode == NetmodeID.Server)


There isn't much value in commenting this as it wont ever make it to a release build due to the preprocessor statements, If we truly think this logging is unhelpful we should look at removing it completely

ScalarVector1 · 2026-05-20T19:44:51Z

+
+			if (IsActive)
+			{
+				// Draw yellow outline if the tool is active


nit: misleading comment, outline will be opposite hue/value to selected button color, not yellow

ScalarVector1 · 2026-05-20T19:48:40Z

+			SmartUIState topmost = GetTopmostHoveredState();
+			bool result = owner is not null && ReferenceEquals(owner, topmost);
+
+			string elementName = element.GetType().Name;


These should be in the preprocessor if block as they're only relevant to the logging

ScalarVector1 · 2026-05-20T19:51:27Z

+
+			int index = UIStates.IndexOf(state);
+
+			if (index < 0 || index >= UserInterfaces.Count)


Is there a case where these indicies could become out of sync? What happens if one of these adds or RemoveAts throws while the other does not? Perhaps we should introduce some dictioanry or other mapping structure to pair them up?

Cleaner UI loader

emyhrberg added 5 commits December 12, 2025 20:54

Fixed admin permissions.

3f11cd7

dladmin now works properly. 👍

Added so all UIStates are no longer visible or updated for non-admins

91186c5

Comment out some Logger calls

06afb88

ScalarVector1 reviewed May 20, 2026

View reviewed changes

ScalarVector1 and others added 2 commits May 20, 2026 18:35

Cleaner UI loader

dd62f44

Merge pull request #1 from ScalarVector1/cleaner-ui-loader

c7b72d7

Cleaner UI loader

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Player manager and UI improvements#158

Player manager and UI improvements#158
emyhrberg wants to merge 7 commits into
ScalarVector1:masterfrom
emyhrberg:player-manager-and-ui-improvements

emyhrberg commented May 10, 2026

Uh oh!

ScalarVector1 left a comment

Uh oh!

ScalarVector1 May 20, 2026

Uh oh!

ScalarVector1 May 20, 2026

Uh oh!

ScalarVector1 May 20, 2026

Uh oh!

ScalarVector1 May 20, 2026

Uh oh!

ScalarVector1 May 20, 2026

Uh oh!

ScalarVector1 May 20, 2026

Uh oh!

ScalarVector1 May 20, 2026

Uh oh!

ScalarVector1 May 20, 2026

Uh oh!

ScalarVector1 May 20, 2026

Uh oh!

ScalarVector1 May 20, 2026

Uh oh!

ScalarVector1 May 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants


		int index = UIStates.IndexOf(state);

		if (index < 0 \|\| index >= UserInterfaces.Count)

Conversation

emyhrberg commented May 10, 2026

Adds the new Player Manager (Browser) with new buttons:

UI interaction improvements

Misc:

Demo

Uh oh!

ScalarVector1 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants