Add SoB + LFX selections, close /join with a two-futures band, and stop the desk from cloning its remit onto every hover card - #4
Merged
PRAteek-singHWY merged 3 commits intoSep 4, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wall is no longer GSoC-only
First non-GSoC entries in
SELECTIONS: one Summer of Bitcoin row, one LFX row. Sametuple shape and rules as the GSoC arrays.
Vivek Singh Solanki appears twice on purpose (GSoC + LFX) — the wall lists selections,
not people, and everything counting people dedupes by name. He's also a different
person from the "Vivek Singh" in SoB. Both noted in source.
Hardcoded "fifteen" removed from prose comments across
CommunityBanner,ContribWall,Hall,Terminal,club.ts— the count moves as names come in.Comments only.
New
ProgrammeInfo.oursThe "Who from SST has done it" row stays derived from
SELECTIONSfor selectiveprogrammes — that's what keeps this page and the Hall of Fame in agreement. But GSSoC
and Hacktoberfest are participation programmes, so the honest answer is a count plus
whoever stood out, which no
Selectionrow can express without inventing a selection.Optional prose field, rendered above the derived names so neither can silently hide
the other.
/join closing band
Contrasts "if you close this tab" against "if you hit the button". Deliberately not a
NextAction— no link at all, because an exit under a half-filled form loses theapplication. On the page rather than in
ApplyForm, where it read as a thirddisclaimer.
Desk hover cards
The desk was pushing its remit onto all four members, so four faces popped the same
paragraph.
remitoverride prop removed with its only caller; the remit still appearsonce in the stacked list below, where it's read aloud. That exposed a latent bug —
three of four members carry only a name, and an empty
.person-tiprenders as a smalldark rectangle on hover.
Nodenow skips the bubble when there's nothing to say.Review notes
NumbersStripdedupes with the duplicated name present.url, same as all existing ones — still the open gap.text-*on.labelis a no-op (declared after@tailwind utilities), so the band'sasymmetry rides on body copy and the accent rule.