[pdfx] Align default image format with native implementation (JPEG → PNG)#581
Open
ktanaka101 wants to merge 1 commit intoScerIO:mainfrom
Open
[pdfx] Align default image format with native implementation (JPEG → PNG)#581ktanaka101 wants to merge 1 commit intoScerIO:mainfrom
ktanaka101 wants to merge 1 commit intoScerIO:mainfrom
Conversation
The public docs—and the native Android / iOS layers—treat PNG as the default output format when `format` is omitted, but the Dart signature still defaulted to `PdfPageImageFormat.jpeg`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What & Why
Both the public docs and the native Android / iOS layers say
PdfPage.render()defaults to PNG whenformatis omitted.The Dart signature, however, still defaulted to
PdfPageImageFormat.jpeg.That mismatch triggers a false-positive from the
avoid_redundant_argument_valueslinter: it tells you to drop the argument, but doing so would silently
change the result from JPEG → PNG.
This PR aligns the Dart default with reality:
Tests
Added
test/pdfx_test.dart.Impact
Thanks for reviewing!